1179494 - Fix flake8 warnings in OrangeFactor

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect, P3)

Description

[Ed Morley [:emorley]]

./sendemail.py:19:31: E701 multiple statements on one line (colon)
./sendemail.py:19:40: F821 undefined name 'stderr'
./sendemail.py:28:67: W291 trailing whitespace
./sendemail.py:33:1: W293 blank line contains whitespace
./sendemail.py:37:1: W293 blank line contains whitespace
./server/woo_server.py:5:1: F401 'mozmiddleware' imported but unused
./server/woo_server.py:11:1: E302 expected 2 blank lines, found 1
./server/woo_server.py:21:1: W293 blank line contains whitespace
./server/mozmiddleware.py:13:1: E302 expected 2 blank lines, found 1
./server/mozmiddleware.py:14:1: W293 blank line contains whitespace
./server/mozmiddleware.py:22:1: W293 blank line contains whitespace
./server/mozmiddleware.py:24:80: E501 line too long (85 > 79 characters)
./server/mozmiddleware.py:26:30: E231 missing whitespace after ','
./server/mozmiddleware.py:27:30: E231 missing whitespace after ','
./server/mozmiddleware.py:35:46: E701 multiple statements on one line (colon)
./server/mozmiddleware.py:45:1: W293 blank line contains whitespace
./server/update_testfailures.py:33:16: E201 whitespace after '{'
./server/update_testfailures.py:34:40: E225 missing whitespace around operator
./server/update_testfailures.py:34:64: E202 whitespace before '}'
./server/update_testfailures.py:59:44: W291 trailing whitespace
./server/update_testfailures.py:125:1: W293 blank line contains whitespace
./woo_mailer.py:19:80: E501 line too long (120 > 79 characters)
./woo_mailer.py:20:80: E501 line too long (159 > 79 characters)
./woo_mailer.py:30:80: E501 line too long (122 > 79 characters)
./woo_mailer.py:40:1: E302 expected 2 blank lines, found 1
./woo_mailer.py:53:80: E501 line too long (82 > 79 characters)
./woo_mailer.py:56:80: E501 line too long (112 > 79 characters)
./woo_mailer.py:57:80: E501 line too long (89 > 79 characters)
./woo_mailer.py:59:80: E501 line too long (100 > 79 characters)
./woo_mailer.py:97:80: E501 line too long (105 > 79 characters)
./woo_mailer.py:98:1: W293 blank line contains whitespace
./woo_mailer.py:104:17: E401 multiple imports on one line
./woo_mailer.py:106:1: W293 blank line contains whitespace
./woo_mailer.py:109:80: E501 line too long (96 > 79 characters)
./woo_mailer.py:111:80: E501 line too long (96 > 79 characters)
./woo_mailer.py:113:1: W293 blank line contains whitespace
./woo_mailer.py:121:80: E501 line too long (146 > 79 characters)
./woo_mailer.py:127:80: E501 line too long (110 > 79 characters)
./woo_mailer.py:129:1: W293 blank line contains whitespace
./woo_mailer.py:149:1: W293 blank line contains whitespace
./woo_mailer.py:154:1: W293 blank line contains whitespace
./woo_mailer.py:159:1: W293 blank line contains whitespace
./woo_mailer.py:171:80: E501 line too long (82 > 79 characters)
./woo_mailer.py:176:80: E501 line too long (86 > 79 characters)
./woo_mailer.py:177:80: E501 line too long (273 > 79 characters)
./woo_mailer.py:185:1: W293 blank line contains whitespace
./woo_mailer.py:189:1: W293 blank line contains whitespace
./woo_mailer.py:192:1: W293 blank line contains whitespace
./woo_mailer.py:233:80: E501 line too long (94 > 79 characters)
./woo_mailer.py:271:27: E401 multiple imports on one line
./server/handlers.py:11:1: F401 'math' imported but unused
./server/handlers.py:147:36: E225 missing whitespace around operator
./server/handlers.py:156:25: E711 comparison to None should be 'if cond is None:'
./server/handlers.py:165:23: E711 comparison to None should be 'if cond is None:'
./server/handlers.py:175:5: E303 too many blank lines (2)
./server/handlers.py:206:80: E501 line too long (80 > 79 characters)
./server/handlers.py:221:80: E501 line too long (80 > 79 characters)
./server/handlers.py:243:80: E501 line too long (92 > 79 characters)
./server/handlers.py:285:9: E265 block comment should start with '# '
./server/handlers.py:286:9: E265 block comment should start with '# '
./server/handlers.py:305:16: E713 test for membership should be 'not in'
./server/handlers.py:316:21: E129 visually indented line with same indent as next logical line
./server/handlers.py:321:21: E129 visually indented line with same indent as next logical line
./server/handlers.py:337:26: E201 whitespace after '{'
./server/handlers.py:337:37: E231 missing whitespace after ':'
./server/handlers.py:338:33: E231 missing whitespace after ':'
./server/handlers.py:339:35: E231 missing whitespace after ':'
./server/handlers.py:340:38: E231 missing whitespace after ':'
./server/handlers.py:341:33: E231 missing whitespace after ':'
./server/handlers.py:342:38: E231 missing whitespace after ':'
./server/handlers.py:343:32: E231 missing whitespace after ':'
./server/handlers.py:344:37: E231 missing whitespace after ':'
./server/handlers.py:345:38: E231 missing whitespace after ':'
./server/handlers.py:346:40: E231 missing whitespace after ':'
./server/handlers.py:347:25: E124 closing bracket does not match visual indentation
./server/handlers.py:375:80: E501 line too long (110 > 79 characters)
./server/handlers.py:384:9: E265 block comment should start with '# '
./server/handlers.py:386:80: E501 line too long (80 > 79 characters)
./server/handlers.py:394:5: E265 block comment should start with '# '

Comment 1

[Ed Morley [:emorley]]

https://hg.mozilla.org/automation/orangefactor/rev/3b6e7d13b9ab
https://hg.mozilla.org/automation/orangefactor/rev/5f395743d4c7
https://hg.mozilla.org/automation/orangefactor/rev/e575f5e838eb
(Ignored the line length warnings)

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/automation/orangefactor/rev/f657c78a0fcd