Remove branchSub32 explicit instantiations and unused code

RESOLVED FIXED in Firefox 42

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sstangl, Assigned: sstangl)

Tracking

unspecified
mozilla42
Other
Unspecified
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8628507 [details] [diff] [review]
0001-Remove-extraneous-and-unused-MacroAssembler-ARM64-co.patch

This fixes an ARM64 crash in asm.js/bug941877.js when run with "--no-ion --ion-eager --no-asmjs".

ARM64's MacroAssembler has a correct templatized implementation of branchSub32(), but for some mysterious reason also has explicit versions that are MOZ_CRASH().

This patch also removes some functions that are never used, including two on ARM that also got copied into the ARM64 port.
Attachment #8628507 - Flags: review?(efaustbmo)
(Assignee)

Updated

3 years ago
Assignee: nobody → sstangl
(Assignee)

Updated

3 years ago
Blocks: 1179514
No longer blocks: 1088326

Comment 1

3 years ago
Comment on attachment 8628507 [details] [diff] [review]
0001-Remove-extraneous-and-unused-MacroAssembler-ARM64-co.patch

Review of attachment 8628507 [details] [diff] [review]:
-----------------------------------------------------------------

APPROVED.
Attachment #8628507 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/mozilla-central/rev/0fa2a8d57fc6
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.