All users were logged out of Bugzilla on October 13th, 2018

test_privateBrowsing.html leaves windows behind

RESOLVED FIXED in Firefox 42

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8628571 [details] [diff] [review]
Close the windows opened in private browsing worker tests
Attachment #8628571 - Flags: review?(amarchesini)
Comment on attachment 8628571 [details] [diff] [review]
Close the windows opened in private browsing worker tests

Review of attachment 8628571 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/serviceworkers/test_privateBrowsing.html
@@ +64,1 @@
>        SimpleTest.finish();

the error is that here we call SimpleTest.finish() but we should call: runTest() instead.
If you see, when there are not steps to do, we close the windows.

::: dom/workers/test/test_sharedWorker_privateBrowsing.html
@@ +69,5 @@
>            var sharedWorker3 = new wP.content.SharedWorker('sharedWorker_privateBrowsing.js');
>            sharedWorker3.port.onmessage = function(event) {
>              is(event.data, 2, "Only 2 sharedworker expected in the private window");
> +            wN.close();
> +            wP.close();

same here.
Attachment #8628571 - Flags: review?(amarchesini) → review-
(Assignee)

Comment 3

3 years ago
Created attachment 8628786 [details] [diff] [review]
Close the windows opened in private browsing worker tests
Attachment #8628571 - Attachment is obsolete: true
Attachment #8628786 - Flags: review?(amarchesini)
Attachment #8628786 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/17e6afe399ad
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.