1179548 - test_privateBrowsing.html leaves windows behind

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Comment 1

[(no longer active)]

Attachment: Close the windows opened in private browsing worker tests

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8628571 [details] [diff] [review]
Close the windows opened in private browsing worker tests

Review of attachment 8628571 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/serviceworkers/test_privateBrowsing.html
@@ +64,1 @@
>        SimpleTest.finish();

the error is that here we call SimpleTest.finish() but we should call: runTest() instead.
If you see, when there are not steps to do, we close the windows.

::: dom/workers/test/test_sharedWorker_privateBrowsing.html
@@ +69,5 @@
>            var sharedWorker3 = new wP.content.SharedWorker('sharedWorker_privateBrowsing.js');
>            sharedWorker3.port.onmessage = function(event) {
>              is(event.data, 2, "Only 2 sharedworker expected in the private window");
> +            wN.close();
> +            wP.close();

same here.

Comment 3

[(no longer active)]

Attachment: Close the windows opened in private browsing worker tests

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/17e6afe399ad

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/17e6afe399ad