Closed Bug 1179548 Opened 4 years ago Closed 4 years ago

test_privateBrowsing.html leaves windows behind

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attachment #8628571 - Flags: review?(amarchesini)
Comment on attachment 8628571 [details] [diff] [review]
Close the windows opened in private browsing worker tests

Review of attachment 8628571 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/serviceworkers/test_privateBrowsing.html
@@ +64,1 @@
>        SimpleTest.finish();

the error is that here we call SimpleTest.finish() but we should call: runTest() instead.
If you see, when there are not steps to do, we close the windows.

::: dom/workers/test/test_sharedWorker_privateBrowsing.html
@@ +69,5 @@
>            var sharedWorker3 = new wP.content.SharedWorker('sharedWorker_privateBrowsing.js');
>            sharedWorker3.port.onmessage = function(event) {
>              is(event.data, 2, "Only 2 sharedworker expected in the private window");
> +            wN.close();
> +            wP.close();

same here.
Attachment #8628571 - Flags: review?(amarchesini) → review-
Attachment #8628571 - Attachment is obsolete: true
Attachment #8628786 - Flags: review?(amarchesini)
Attachment #8628786 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/17e6afe399ad
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.