11796 - Cookie problems

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect, P3)

Description

[Paul MacQuiddy]

Cookies at
http://slip/projects/dogbert/test/web/internal/cookies/wa_cookie_name1.html are
not being set. Try clicking on the first name/value pair then click on 'see the
cookies'. You should see name1=value1 under 'Here is your cookie, munch munch'

The cgi for the cookie being set is:
echo "content-type: text/html"
echo "set-cookie: name1=value1"
echo ""
echo "<h1>setting name1=value1</h1>"

The cgi for reading the cookie back is:
echo "content-type: text/html"
echo ""
echo "Here is your cookie (munch munch):<p>"
echo $HTTP_COOKIE"<p>"

I don't know where the problem is, writing or reading the cookie.

This is on all platforms, and is a post-Necko regression, but not a M9 stopper.

Comment 1

[neeti]

I have a fix in hand. Steve can you review this change.

RCS file: /cvsroot/mozilla/extensions/cookie/nsCookie.cpp,v
retrieving revision 1.18
diff -r1.18 nsCookie.cpp
1493c1493
<           cookie_cookieList->InsertElementAt(tmp_cookie_ptr, i);
---
>           cookie_cookieList->InsertElementAt(prev_cookie, i);
cvs server: Diffing macbuild
cvs server: Diffing tests

F:\seamonkey\mozilla\extensions\cookie>

If the change is ok, then if get approval from chofmann I can check it in.

Comment 2

[Stephen P. Morse]

Yep, that sure is a valid correction.  And I can see that such an error would
indeed cause the behavior cited in this report.  So I agree with this change.

Comment 3

[neeti]

Checked in a fix

Comment 4

[Paul MacQuiddy]

verified on all platforms