Closed Bug 1179643 Opened 8 years ago Closed 8 years ago

Intermittent apps/system/test/marionette/browser_navigate_chrome_test.js | Browser - Chrome on browser navigation should show the progressbar

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S4 (07Aug)

People

(Reporter: philor, Assigned: apastor)

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe])

Attachments

(2 files, 2 obsolete files)

[gaia] albertopq:1179643-intermitent-chrome > mozilla-b2g:master
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/32124
46 bytes, text/x-github-pull-request
Details | Review 
      No description provided.
Alberto, can you please take a look at this frequent failure?
Flags: needinfo?(apastor)
Assignee: nobody → apastor
Flags: needinfo?(apastor)
Comment on attachment 8643895 [details] [review]
[gaia] albertopq:1179643-intermitent-chrome > mozilla-b2g:master

Not sure why (I've seen this in several places), but it seems that there is an issue with client.helper.waitForElement. Replacing it with a waitFor + findElement fixes it. Kevin, any idea if this might be a Marionette issue? Thanks!
Attachment #8643895 - Flags: review?(kevingrandon)
Alberto - do you have any test runs on gaia-try to prove this? Seems very strange to me that this would fix it, so maybe it is a problem with marionette, or the element not being in the dom?
Flags: needinfo?(apastor)
(In reply to Kevin Grandon :kgrandon from comment #65)
> Alberto - do you have any test runs on gaia-try to prove this? Seems very
> strange to me that this would fix it, so maybe it is a problem with
> marionette, or the element not being in the dom?

Why is the element not being in the dom a problem? Is not what helper.waitForElement is supposed to do, wait until the element is in the dom? 

I don't remember exact cases, but I remember replacing waitForElement fixing some intermitent issues. I'll try to find some example.

Thanks!
Flags: needinfo?(apastor) → needinfo?(kevingrandon)
I guess I'm mainly looking for a large set of gaia-try runs for this suite after the patch (20+) to illustrate that it is fixed.
Flags: needinfo?(kevingrandon)
Comment on attachment 8643895 [details] [review]
[gaia] albertopq:1179643-intermitent-chrome > mozilla-b2g:master

We can land this, though it feels like we work a bit in the blind if we don't prove it.
Attachment #8643895 - Flags: review?(kevingrandon) → review+
Ah, I see the Gij17 runs now, neat, landing.

In master: https://github.com/mozilla-b2g/gaia/commit/798a428324f26d052b22329eb465dd8a2d1b911a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → FxOS-S4 (07Aug)
:(
Status: RESOLVED → REOPENED
Flags: needinfo?(apastor)
Resolution: FIXED → ---
testonly fix. 20 runs without failure. r=me

https://github.com/mozilla-b2g/gaia/commit/6cc6a2e6e6abf7aa7b3ec37872727f0861cee455
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Flags: needinfo?(apastor)
Resolution: --- → FIXED
I think it's time we accepted the fact that this fix didn't actually work.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

        Attachment #8648639 -
        Attachment is obsolete: true

        Attachment #8667336 -
        Attachment is obsolete: true

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
Closing, as last error was more than 2 weeks ago.
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.