1179666 - Wi-Fi settings should sort network names alphabetically within each signal bar level

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Chris Peterson [:cpeterson]]

iOS sorts the entire list of network names alphabetically. Apple probably assumes users want to find a specific network (by name), not just select the random network with the strongest signal.

Android and Firefox OS appears to sort by precise signal strength, even though the UI only shows four signal bars: Very Good, Good, Average, and Weak. The list appears to be random because networks that fall into the same signal bar bucket will be sorted by a criteria that is not visible to the user (precise signal strength, not number of signal bars).

I think Firefox OS should either:

1. sort the entire list alphabetically (like iOS). This list order is stable even when networks' signal strengths fluctuate!
2. or separate networks into the four signal bar buckets and sort each of those sub-lists alphabetically.

Comment 1

[Bobby Chien]

[Blocking Requested - why for this release]:

Comment 2

[[e-mail]]

let UX decide if we need change current behavior

Comment 3

[Harly Hsu[:harly]]

I think the current design make sense as users typically connect to the Wi-Fi access point that has the strongest signal. But we can alphabetically order the ones that has the same signal bar.

Comment 4

[[e-mail]]

denominate since it's an expected behavior. 

Add it to backlog for `alphabetically order the ones that has the same signal bar`

Comment 5

[[e-mail]]

If you think it's an important improvement, please vote it in `Importance` field

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1179666-wifi-network-sort > mozilla-b2g:master

Comment 7

[Scott Wu [:scottwu]]

Comment on attachment 8682929 [details] [review]
[gaia] scottwu:1179666-wifi-network-sort > mozilla-b2g:master

Thanks to :cpeterson for reviewing, but I think I accidentally overwritten his comments on github..

WiFi networks are now sorted by signal bars and alphabetically. I've added a function in WifiHelper to convert relSignalStrength (0~100) to signal bars (0~4).

Could you take a look as well Fred? :)

Comment 8

[[e-mail]]

Comment on attachment 8682929 [details] [review]
[gaia] scottwu:1179666-wifi-network-sort > mozilla-b2g:master

looks good. it will be nice with some unit test

Comment 9

[Chris Peterson [:cpeterson]]

Comment on attachment 8682929 [details] [review]
[gaia] scottwu:1179666-wifi-network-sort > mozilla-b2g:master

LGTM! Thanks for fixing this bug. :)

Comment 10

[Scott Wu [:scottwu]]

Thanks Fred and Chris! I've added unit test that covers the sorting behaviour.

Merged to master.