Closed Bug 1179683 Opened 5 years ago Closed 4 years ago

Update NotificationHelper to use async l10n API

Categories

(Firefox OS Graveyard :: Gaia::Shared, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

No description provided.
Attached file pull request
Stas, what do you think?
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Attachment #8628687 - Flags: review?(stas)
Comment on attachment 8628687 [details] [review]
pull request

r- because the I believe the code can be simplified by a lot by re-using the promise returned by formatValue and by using Promise.all. See comments in github.

Also, notification helper uses mozL10n.language.{code,direction} which is sync, while in l20n.js L10n.languages is a promise. Should we land something similar in l10n.js to make it easier to write forward-compatible code?  I can take care of it.
Attachment #8628687 - Flags: review?(stas) → review-
Comment on attachment 8628687 [details] [review]
pull request

Aaaand Zibi has already updated the patch.  That was fast, thanks. r+.
Attachment #8628687 - Flags: review- → review+
https://github.com/mozilla-b2g/gaia/commit/a53453d7bdfa6db4c6f6d9a80699aa436c2199a0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.