1179697 - Make files of rejected unlisted versions accessible

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Andreas Wagner [:TheOne] [use NI]]

Reviewers need those files for reference when the developer submits a new version.

Comment 1

[Kris Maglione [:kmag]]

https://github.com/mozilla/olympia/pull/599

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/cc6792aaf01ac04bb30b2fc2c4fd8bc288f61b1b
Bug 1179697: Allow editors to download disabled, unlisted files.

https://github.com/mozilla/olympia/commit/353290b75b729fcb8081da8f513dff486cde815c
Merge pull request #599 from kmaglione/file-upload-download

Bugs 1181741, 1179697: Allow editors to download disabled files, allow staff to download arbitrary uploads.

Comment 3

[Valentina Virlics [:vvalentina], VPN QA]

(In reply to Andreas Wagner [:TheOne] from comment #0)
> Reviewers need those files for reference when the developer submits a new
> version.

Where should those files, be? :)
For an accurate testing please give us some extra-details.
Thanks!

Comment 4

[Andreas Wagner [:TheOne] [use NI]]

STR:
1. Go to the review details page of an add-on with at least one rejected version.
2. For any rejection version, click the "All Platforms", "Windows", "Mac OS X" or "Linux" link to install the file.

Expected: The add-on installation dialog should popup.

Comment 5

[Valentina Virlics [:vvalentina], VPN QA]

Verified on AMO-dev and AMO-stage on FF39(Win 7).
Postfix screencast: http://screencast.com/t/xLTU1ywUkPV
Closing bug.