1179698 - Mobile: Ctrl+T opens a new tab, but the focus is not on the address bar

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[daniel]

User Agent: Mozilla/5.0 (Android; Tablet; rv:38.0) Gecko/38.0 Firefox/38.0
Build ID: 20150528015112
Firefox for Android

Steps to reproduce:

In Firefox Mobile 38.0.5 on Android 4.1, using an external bluetooth keyboard, i hit CTRL+Tab and a new browser tab opens. I begin to type the URL.


Actual results:

As the focus is on the first of the top sites, nothing happens.


Expected results:

The focus should have been on the address bar (it is in firefox desktop), the URL should have been entered in the address bar.

Comment 1

[daniel]

apologies. it is android 4.4.2, not 4.1 as originally stated.

Comment 2

[Jan Henning [:JanH]]

The Tabs.LOADURL_START_EDITING flag added for bug 1413739 means that this can be done now with minimal further effort.

Comment 3

[Jan Henning [:JanH]]

Attachment: Bug 1179698 - Part 0 - Remove superfluous true/false ternary operator.

Somehow I must have overlooked that during review, but if I'm touching something
in the neighbourhood I might just as well clean this up.

Review commit: https://reviewboard.mozilla.org/r/232624/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232624/

Comment 4

[Jan Henning [:JanH]]

Attachment: Bug 1179698 - Part 1 - Put input focus on the URL bar when opening a new tab via keyboard.

Review commit: https://reviewboard.mozilla.org/r/232626/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232626/

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8963731 [details]
Bug 1179698 - Part 0 - Remove superfluous true/false ternary operator.

https://reviewboard.mozilla.org/r/232624/#review238574

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8963732 [details]
Bug 1179698 - Part 1 - Put input focus on the URL bar when opening a new tab via keyboard.

https://reviewboard.mozilla.org/r/232626/#review238576

::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:2172
(Diff revision 1)
>          MmaDelegate.track(NEW_TAB);
>          Tabs.getInstance().addTab();

Use `addTab(Tabs.LOADURL_NONE);`

Comment 7

[Jan Henning [:JanH]]

Comment on attachment 8963731 [details]
Bug 1179698 - Part 0 - Remove superfluous true/false ternary operator.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232624/diff/1-2/

Comment 8

[Jan Henning [:JanH]]

Comment on attachment 8963732 [details]
Bug 1179698 - Part 1 - Put input focus on the URL bar when opening a new tab via keyboard.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232626/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7a004dce76e
Part 0 - Remove superfluous true/false ternary operator. r=jchen
https://hg.mozilla.org/integration/autoland/rev/7cd56bc0b985
Part 1 - Put input focus on the URL bar when opening a new tab via keyboard. r=jchen

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e7a004dce76e
https://hg.mozilla.org/mozilla-central/rev/7cd56bc0b985