Closed Bug 1179703 Opened 9 years ago Closed 9 years ago

[First Time Experience]Try to connect the second wifi, the connected wifi and the current wifi will be connecting at the same time.

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.2 affected, b2g-master verified)

VERIFIED FIXED
FxOS-S9 (16Oct)
blocking-b2g 2.5+
Tracking Status
b2g-v2.2 --- affected
b2g-master --- verified

People

(Reporter: yulan.zhu, Assigned: sfoster)

References

Details

(Whiteboard: [2.2-nexus-5-l] [systemsfe])

Attachments

(7 files)

Attached file log.txt
[1.Description]:
[Flame v2.2&Master][N5 v2.2&master][First Time Experience]With a wifi connected, try to connect another, the connected wifi and the current wifi will be connecting at the same time in FTE.
Occurrence time:11:01
See attachments:log.txt & Video.3gp

[2.Testing Steps]: 
1.Reset device or launch FTE from Developer.
2.Go to "Select a network" page.
3.Connect to a wifi.
4.Connect to another wifi.

[3.Expected Result]: 
4.Only the current wifi should try to connect and the connected wifi should be shown below it.

[4.Actual Result]: 
4.The connected wifi and the current wifi will be connecting at the same time.

[5.Reproduction build]: 
Device: Flame 2.2 build (Affected)
Build ID               20150701162502
Gaia Revision          bd386f346eb1591fddbc84bf034b22700e7e2a58
Gaia Date              2015-06-30 15:53:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f16c1125b9d6
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150701.195343
Firmware Date          Wed Jul  1 19:53:55 EDT 2015
Bootloader             L1TC000118D0

Device: Flame master (Flame 2.5/master)  (Affected)
Build ID               20150701160205
Gaia Revision          858764a56982eb558259ccc689bbee855f090085
Gaia Date              2015-07-01 16:59:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c36f68439496
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150701.193443
Firmware Date          Wed Jul  1 19:34:55 EDT 2015
Bootloader             L1TC000118D0

Device: N5 2.2 build (Affected)
Build ID               20150701162502
Gaia Revision          bd386f346eb1591fddbc84bf034b22700e7e2a58
Gaia Date              2015-06-30 15:53:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f16c1125b9d6
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150701.195806
Firmware Date          Wed Jul  1 19:58:26 EDT 2015
Bootloader             HHZ12f

Device: N5 master (N5 2.5/master) (Affected)
Build ID               20150701160205
Gaia Revision          858764a56982eb558259ccc689bbee855f090085
Gaia Date              2015-07-01 16:59:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c36f68439496
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150701.193431
Firmware Date          Wed Jul  1 19:34:50 EDT 2015
Bootloader             HHZ12f

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
Free Test
Attached video Video.3GP
Please don't add me to non l10n or RTL bugs. thanks
I'm curious if the same bug is present in Settings? That would help narrow the issue down as FTU app shares most of the wifi code with Settings.
Keywords: qawanted
Whiteboard: [2.2 nexus-5-l] → [2.2-nexus-5-l] [systemsfe]
Attached video Video for Settings.3GP
Hi Sam,
This issue dose not exist in Settings, when you connect to a wifi and connect to another wifi, only the current wifi will try to connect, please refer to the video: Video for Settings.3GP.
Thanks!
Flags: needinfo?(sfoster)
QA Whiteboard: [MGSEI-Triage+]
Keywords: qawanted
> This issue dose not exist in Settings, when you connect to a wifi and
> connect to another wifi, only the current wifi will try to connect

Thanks for confirming that. We should get this fixed

[Blocking Requested - why for this release]: Confusing UX, inconsistent with equivalent functionality in Settings app
blocking-b2g: --- → 2.5?
Flags: needinfo?(sfoster)
Priority: -- → P1
blocking-b2g: 2.5? → 2.5+
Priority: P1 → P2
I can't reproduce this issue on a Z3C with todays nightly. Can QA check again?
Keywords: qawanted
Attached video Aries_KK v2.5.3gp
This bug can be repro on latest build of Aries KK v2.5 by the STR in comment 0.
Actual result: The connected wifi and the current wifi will be connecting at the same time.
See attachment: Aries_KK v2.5.3gp and logcat_2343.txt
Reproduce rate: 10/10

Device: Aries KK v2.5 (Affected)
Build ID               20151013181426
Gaia Revision          d400cda6bf0f8b30dcf7d7d71bfa61f29a3f1588
Gaia Date              2015-10-13 06:42:17
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/2387ada864282880d3a498d643abe3d8b887ee59
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151013.174418
Firmware Date          Tue Oct 13 17:44:27 UTC 2015
Bootloader             s1
Attached file logcat_2343.txt
Keywords: qawanted
When I watch the WifiManager.api.onstatuschange when running through the STR here, I see: 
onstatuschange:  THE-BARNLIGHT disconnected wifi.js:149:9
onstatuschange:  THE-BARNLIGHT connecting wifi.js:149:9
onstatuschange:  CodeChopsAP24 connecting wifi.js:149:9
onstatuschange:  CodeChopsAP24 associated wifi.js:149:9
onstatuschange:  CodeChopsAP24 connected wifi.js:149:9

So, I get a disconnect status for the first network, then a connecting status for the first network, and then a connecting status for the 2nd network. With every status change we update the corresponding element - so its actually technically doing the right thing. 

I'll see if I can debounce or track state a bit to improve this for the short-term, but that looks like a bug lower down the stack to me.
Assignee: nobody → sfoster
Target Milestone: --- → FxOS-S9 (16Oct)
See Also: → 1216221
Comment on attachment 8675805 [details] [review]
[gaia] sfoster:ftu-wifi-bug-1179703 > mozilla-b2g:master

Looks like fcampo and Manuel Casas were the last to make significant changes in wifi.js, but it seems neither is active (sorry I don't know Manuel, perhaps bugzilla knows him by another name.), Defaulting to Francisco for review. Feel free to forward along.
Attachment #8675805 - Flags: review?(francisco)
Comment on attachment 8675805 [details] [review]
[gaia] sfoster:ftu-wifi-bug-1179703 > mozilla-b2g:master

Hei Sam, pretty clear PR. LGTM.

Left some nit comments on github but everything looks good to me.
Attachment #8675805 - Flags: review?(francisco) → review+
PR updated with nits. Thanks Francisco, I did end up creating the status constants. 

Merged to master: https://github.com/mozilla-b2g/gaia/commit/01f886b8177a2765c125fa94582047a4265c9341
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
This bug has been verified as "pass" on the latest build of Flame KK v2.5 and Aries KK v2.5 by the STR in comment 0.

Actual result: Only the current wifi try to connect and the connected wifi are shown below it.
See attachment: verified_Aries KK_v2.5.3gp.
Reproduce rate: 0/10.


Device: Flame KK 2.5 (Pass)
Build ID               20151022150207
Gaia Revision          29ce8ec8606e59f582375234440812b046346513
Gaia Date              2015-10-22 05:31:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/76bd0c01d72e64ca4f261ffdb2652a91f961e930
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151022.185000
Firmware Date          Thu Oct 22 18:50:13 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20151023005002
Gaia Revision          29ce8ec8606e59f582375234440812b046346513
Gaia Date              2015-10-22 05:31:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1f03a14106e59280761ac53904340f389674337f
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151023.001128
Firmware Date          Fri Oct 23 00:11:35 UTC 2015
Bootloader             s1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: