Open Bug 1179711 Opened 9 years ago Updated 2 years ago

GETXPROP is not supported in ionmonkey

Categories

(Core :: JavaScript Engine: JIT, defect, P5)

defect

Tracking

()

People

(Reporter: h4writer, Unassigned)

References

(Blocks 1 open bug)

Details

I haven't looked into this too long. Just noticed that we will abort ionmonkey if we get GETXPROP. Not sure when the parser will emit it. Though if it is often, we should definitely look into adding this to ionmonkey!
> Not sure when the parser will emit it.

I _think_ GETXPROP will get emitted for code like this:

  x += 5;

but only when the assignment to x would need to be a setname.  If x is a global, we do bindgname+getgname instead of bindname+getxprop.  If x is a local or arg or aliased var we end up with getlocal/getarg/getaliasedvar instead of getxprop.

Note also bug 1145641, though.
Blocks: 1145641
We could add a MIR instruction that calls GetPropertyForNameLookup. GETXPROP is pretty rare so a VM call (or shared stub later) seems fine to avoid aborting completely..
> GETXPROP is pretty rare 

Well, unless we fix bug 1145641.
P5 because GETXPROP is pretty uncommon in normal code.
Priority: -- → P5
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.