Closed Bug 1179712 Opened 10 years ago Closed 10 years ago

Create a Pin Card component

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S2 (10Jul)

People

(Reporter: apastor, Assigned: apastor)

References

Details

(Keywords: feature, Whiteboard: [systemsfe])

Attachments

(1 file)

Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30802
46 bytes, text/x-github-pull-request
benfrancis
: review+
kgrandon
: review+
Details | Review
Assignee: nobody → apastor
Attachment #8628887 - Flags: review?(bfrancis)
Target Milestone: --- → FxOS-S2 (10Jul)
Comment on attachment 8628887 [details] [review] Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30802 Thanks Alberto, I will try to review this properly later today but can you swap out the default pin icon for the icons Eric provided in bug 1174813? Also, I think we need a peer of the Shared module to review this as well, flagging Kevin.
Attachment #8628887 - Flags: review?(kgrandon)
Comment on attachment 8628887 [details] [review] Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30802 R+ with nits on github, thanks!
Attachment #8628887 - Flags: review?(kgrandon) → review+
Comment on attachment 8628887 [details] [review] Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30802 thanks
Attachment #8628887 - Flags: review?(bfrancis) → review+
master: https://github.com/mozilla-b2g/gaia/commit/20e6960417b67d6f54032c62ce462987bb86a819
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: