Create a Pin Card component

RESOLVED FIXED in FxOS-S2 (10Jul)

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: apastor, Assigned: apastor)

Tracking

({feature})

unspecified
FxOS-S2 (10Jul)
ARM
Gonk (Firefox OS)
feature

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Assignee)

Updated

3 years ago
Assignee: nobody → apastor
(Assignee)

Updated

3 years ago
Attachment #8628887 - Flags: review?(bfrancis)
Target Milestone: --- → FxOS-S2 (10Jul)
Comment on attachment 8628887 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30802

Thanks Alberto, I will try to review this properly later today but can you swap out the default pin icon for the icons Eric provided in bug 1174813?

Also, I think we need a peer of the Shared module to review this as well, flagging Kevin.
Attachment #8628887 - Flags: review?(kgrandon)
Comment on attachment 8628887 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30802

R+ with nits on github, thanks!
Attachment #8628887 - Flags: review?(kgrandon) → review+
Comment on attachment 8628887 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30802

thanks
Attachment #8628887 - Flags: review?(bfrancis) → review+
(Assignee)

Comment 5

3 years ago
master: https://github.com/mozilla-b2g/gaia/commit/20e6960417b67d6f54032c62ce462987bb86a819
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.