Closed Bug 1179771 Opened 4 years ago Closed 4 years ago

Update B2G Installer for ADB Helper 0.8.0

Categories

(Firefox OS Graveyard :: B2gInstaller, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
FxOS-S2 (10Jul)

People

(Reporter: jryans, Assigned: gerard-majax)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

PR
46 bytes, text/x-github-pull-request
jryans
: review+
Details | Review
In bug 1026945, ADB Helper was changed so that ADB polling no longer begins on Firefox startup.

The B2G Installer add-on should be updated to emit the events "adb-start-polling" and "adb-stop-polling", similar to fastboot.
The ADB Helper changes were just merged[1].

I plan to release the changes as ADB Helper 0.8.0 very soon.

Alexandre, should I wait for B2G Installer to be updated before releasing a new ADB Helper?

[1]: https://github.com/mozilla/adbhelper/commit/363525cda5f989c455dc159beee8aacb5801daa9
Flags: needinfo?(lissyx+mozillians)
No, we have not made the addon widely available, and each distribution channel also comes with the ADB Helper forked. So we'll add support for the new version to kill the fork but this will be done in a couple of days, and you should not refrain your release :).
Flags: needinfo?(lissyx+mozillians)
Assignee: nobody → lissyx+mozillians
Dale, we likely want to fix this bug before you can finish and land bug 1177280
Blocks: 1177280
Flags: needinfo?(dale)
Attached file PR
Does it looks okay to you? I have not yet checked, I'm in the middle of a device crisis :)
Attachment #8628889 - Flags: review?(jryans)
Comment on attachment 8628889 [details] [review]
PR

Looks reasonable to me!
Attachment #8628889 - Flags: review?(jryans) → review+
Comment on attachment 8628889 [details] [review]
PR

Actually, is it possible to delay start ADB until the user sees some UI for this addon?

It seems like the current PR would bring back the issue of starting ADB on Firefox startup, so it would be nice to avoid that if possible.
Attachment #8628889 - Flags: review+
Comment on attachment 8628889 [details] [review]
PR

Like this?
Attachment #8628889 - Flags: review?(jryans)
Comment on attachment 8628889 [details] [review]
PR

That seems nicer, thanks!
Attachment #8628889 - Flags: review?(jryans) → review+
So the polling start seems to work properly, and I do emit the stop event on unload event listener. But after doing this, I still see the ADB Helper addon being active.

That is, enabling ADB Helper debugging, I still see stuff from it in the JS Console after I unload my about:b2g-installer page.
Flags: needinfo?(jryans)
I see the same behavior with WebIDE: ADB Helper is still active after I close the window ...
> Dale, we likely want to fix this bug before you can finish and land bug 1177280

Cool will take a look an integrate the changes, cheers for this, apologies for being slow getting my changes back up, moving time for me but will try for it asap
Flags: needinfo?(dale)
(In reply to Alexandre LISSY :gerard-majax from comment #9)
> So the polling start seems to work properly, and I do emit the stop event on
> unload event listener. But after doing this, I still see the ADB Helper
> addon being active.
> 
> That is, enabling ADB Helper debugging, I still see stuff from it in the JS
> Console after I unload my about:b2g-installer page.

Hmm.  One data point is that I think ADB Helper only closes properly with the following versions:

* Nightly 42 (2015-07-01) (needs https://hg.mozilla.org/mozilla-central/rev/fd6075b203c9)
* ADB Helper 0.8.0

Prior to the WebIDE / Firefox changeset above, ADB will remain alive, but this is not very different than previous behavior for those Firefox versions, since ADB used to open at Firefox startup and never close.

So, assuming you have those versions, here is the test I performed:

1. Close Firefox first
2. In terminal, look for ADB servers: ps aux | grep adb
3. If they exist: adb kill-server
4. Start Firefox with ADB Helper 0.8.0
5. Check ps aux | grep adb, no server is running yet
6. Open WebIDE
7. Check ps aux | grep adb, now server is running
8. Close WebIDE
9. Check ps aux | grep adb, server has been stopped

Now, ADB Helper will also cooperate with an ADB server that was started outside Firefox as well.  I only killed the server first as a simpler testing mechanism.

Does this match the behavior you see without B2G Installer add-on installed?  Does adding B2G Installer then cause this behavior to change?
Flags: needinfo?(jryans) → needinfo?(lissyx+mozillians)
Right, so I think the key point was making sure the ADB server was started by the addon. If not, then we do not kill it. I think it's okay then, thanks !
Flags: needinfo?(lissyx+mozillians)
https://github.com/lissyx/b2g-installer/commit/70192a02d61f0513b754edb80237cd222139d3c7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → FxOS-S2 (10Jul)
Component: General → B2gInstaller
You need to log in before you can comment on or make changes to this bug.