1179826 - Shutdown assert in MediaStreamGraph EnsureRunInStableState

Status: RESOLVED WORKSFORME

(Core :: Audio/Video: MediaStreamGraph, defect, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

Attachment: msg_failure_shutdown gdb log (plugin-container)

inbound from yesterday, with bug 950660 patches (should be irrelevant).  e10s active, linux64 debug build.

Assertion failure in RunInStableState called from MSG - too late in shutdown (we're cleaning out the last CC run).  

Attached is stack, info on threads, dump of the Graph object, etc.

STR:
Loaded, started talky.io call with another local machine (using TCP-TURN), ended call, selected Leave, filled out and submitted feedback, then clicked close box on window.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

bug 1182467 may provide a reliable way to reproduce this race/assert

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Bug 1179909 is going to change this code so that the final cycle collection is not "too late" to do RunInStableState (although I probably need to reorder things in that patch so that its also after the final GC).

Comment 4

[Paul Adenot (:padenot)]

Clearing NEEDINFO in light of comment 3. If this still happens again, please NI again.

Comment 5

[Kaustabh Datta Choudhury]

A recent push to try showed up the following oranges : https://treeherder.mozilla.org/#/jobs?repo=try&revision=d604fe0b4eb3&filter-searchStr=windows%20xp&filter-tier=1&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified

Comment 6

[Kaustabh Datta Choudhury]

Here's a recent push to try : https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff6fea1acd4f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

We do have test_ipc.html disabled as a result of this bug:
https://dxr.mozilla.org/mozilla-central/source/dom/media/tests/mochitest/ipc/mochitest.ini?offset=100#9

I am not sure how we got here, it looks like the bug filed for the issue (bug 1182467) was marked as a duplicate of this bug.

:padenot, is there somebody who could own working on this?  I am not sure if this is a known issue to anyone who cares about this leak or test case.

Comment 8

[Paul Adenot (:padenot)]

It would be worth it to do another try push, we changed a lot of things. Then we can find an owner if there still are problems.

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

pushed to try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7e3d0db3db4

We should have results tomorrow!

Comment 10

[Karl Tomlinson (:karlt)]

Changes in Bug 1179909 would have changed the behavior here I expect, but it may now be a shutdown leak.

mDetectedNotRunning is not set in the AppendMessage() call, I guess because threaded-ml did not finish before the main thread stopped receiving events.
Now that the MSG thread is not necessarily an XPCOM thread, XPCOM will not wait for that thread to shut down before closing the main thread.

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: enable dom/media/.../test_ipc.html again (1.0)

this is really unrelated to this bug, but when bug 1182467 was filed, we filed it and disabled test_ipc.html- now it appears that we don't have a problem with it:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7e3d0db3db4

Comment 12

[Paul Adenot (:padenot)]

Comment on attachment 8667139 [details] [diff] [review]
enable dom/media/.../test_ipc.html again (1.0)

Review of attachment 8667139 [details] [diff] [review]:
-----------------------------------------------------------------

Let's land this. If something goes wrong again, we'll have a more in depth look.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41c45fa8ce5e

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/41c45fa8ce5e

Comment 15

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:drno, maybe it's time to close this bug?