Closed Bug 117990 Opened 23 years ago Closed 22 years ago

CornerView::Paint() does a CreateInstance of an nsILookAndFeel object

Categories

(Core :: Layout, defect, P1)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: sfraser_bugs, Assigned: sfraser_bugs)

Details

(Keywords: perf)

Attachments

(1 file)

CornerView::Paint(), in nsScrollingView.cpp, does this:

      nsComponentManager::CreateInstance(kLookAndFeelCID, nsnull,
                                         NS_GET_IID(nsILookAndFeel), (void **)&
mLookAndFeel);


which is bad because nsILookAndFeel is a service, and may have some expensive 
initialization code.
Taking this bug
Assignee: attinasi → kmcclusk
Target Milestone: --- → mozilla1.0.1
Bulk moving Mozilla1.01 bugs to future-P1. I will pull from the future-P1 list
to schedule bugs for post Mozilla1.0 milestones
Priority: -- → P1
Target Milestone: mozilla1.0.1 → Future
Keywords: perf
Taking
Assignee: kmcclusk → sfraser
Target Milestone: Future → ---
Attachment #109722 - Flags: superreview?(dbaron)
Attachment #109722 - Flags: review?(kmcclusk)
Note: I'm going to nuke the 
  static NS_DEFINE_IID(kIClipViewIID, NS_ICLIPVIEW_IID);
in that file, since it's unused.
Status: NEW → ASSIGNED
Attachment #109722 - Flags: superreview?(dbaron) → superreview+
Comment on attachment 109722 [details] [diff] [review]
Use do_GetService to get the nsILookAndFeel service

r=peterl
Attachment #109722 - Flags: review?(kmcclusk) → review+
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Keywords: nsbeta1+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: