Closed
Bug 117990
Opened 24 years ago
Closed 23 years ago
CornerView::Paint() does a CreateInstance of an nsILookAndFeel object
Categories
(Core :: Layout, defect, P1)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: sfraser_bugs, Assigned: sfraser_bugs)
Details
(Keywords: perf)
Attachments
(1 file)
|
3.81 KB,
patch
|
peterlubczynski-bugs
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
CornerView::Paint(), in nsScrollingView.cpp, does this:
nsComponentManager::CreateInstance(kLookAndFeelCID, nsnull,
NS_GET_IID(nsILookAndFeel), (void **)&
mLookAndFeel);
which is bad because nsILookAndFeel is a service, and may have some expensive
initialization code.
|
||
Comment 1•24 years ago
|
||
Taking this bug
Assignee: attinasi → kmcclusk
Target Milestone: --- → mozilla1.0.1
|
|
||
Comment 2•24 years ago
|
||
Bulk moving Mozilla1.01 bugs to future-P1. I will pull from the future-P1 list
to schedule bugs for post Mozilla1.0 milestones
Priority: -- → P1
Target Milestone: mozilla1.0.1 → Future
|
Assignee | |
Comment 4•23 years ago
|
||
|
|
Assignee | |
Updated•23 years ago
|
Attachment #109722 -
Flags: superreview?(dbaron)
Attachment #109722 -
Flags: review?(kmcclusk)
|
|
Assignee | |
Comment 5•23 years ago
|
||
Note: I'm going to nuke the
static NS_DEFINE_IID(kIClipViewIID, NS_ICLIPVIEW_IID);
in that file, since it's unused.
Status: NEW → ASSIGNED
Attachment #109722 -
Flags: superreview?(dbaron) → superreview+
|
|
||
Comment 6•23 years ago
|
||
Comment on attachment 109722 [details] [diff] [review]
Use do_GetService to get the nsILookAndFeel service
r=peterl
Attachment #109722 -
Flags: review?(kmcclusk) → review+
|
|
Assignee | |
Comment 7•23 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•