CornerView::Paint() does a CreateInstance of an nsILookAndFeel object

RESOLVED FIXED

Status

()

Core
Layout
P1
normal
RESOLVED FIXED
16 years ago
15 years ago

People

(Reporter: Simon Fraser, Assigned: Simon Fraser)

Tracking

({perf})

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
CornerView::Paint(), in nsScrollingView.cpp, does this:

      nsComponentManager::CreateInstance(kLookAndFeelCID, nsnull,
                                         NS_GET_IID(nsILookAndFeel), (void **)&
mLookAndFeel);


which is bad because nsILookAndFeel is a service, and may have some expensive 
initialization code.
Taking this bug
Assignee: attinasi → kmcclusk
Target Milestone: --- → mozilla1.0.1
Bulk moving Mozilla1.01 bugs to future-P1. I will pull from the future-P1 list
to schedule bugs for post Mozilla1.0 milestones
Priority: -- → P1
Target Milestone: mozilla1.0.1 → Future

Updated

16 years ago
Keywords: perf
(Assignee)

Comment 3

15 years ago
Taking
Assignee: kmcclusk → sfraser
Target Milestone: Future → ---
(Assignee)

Comment 4

15 years ago
Created attachment 109722 [details] [diff] [review]
Use do_GetService to get the nsILookAndFeel service
(Assignee)

Updated

15 years ago
Attachment #109722 - Flags: superreview?(dbaron)
Attachment #109722 - Flags: review?(kmcclusk)
(Assignee)

Comment 5

15 years ago
Note: I'm going to nuke the 
  static NS_DEFINE_IID(kIClipViewIID, NS_ICLIPVIEW_IID);
in that file, since it's unused.
Status: NEW → ASSIGNED
Attachment #109722 - Flags: superreview?(dbaron) → superreview+

Comment 6

15 years ago
Comment on attachment 109722 [details] [diff] [review]
Use do_GetService to get the nsILookAndFeel service

r=peterl
Attachment #109722 - Flags: review?(kmcclusk) → review+
(Assignee)

Comment 7

15 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Updated

15 years ago
Keywords: nsbeta1+
You need to log in before you can comment on or make changes to this bug.