1179917 - On the navigation toolbar, icons and bookmarks are pushed away by the address field when dragging a tab on the toolbar.

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[clej37]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150602115007

Steps to reproduce:

1. Menu/Customize
2. Move the 'bookmark toolbar item' into the navigation toolbar
3. Exit Customize
4. Drag a tab above the address field

Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0


Actual results:

The address field get resized, hiding all icons and bookmarks in an additional menu accessible with a button ">>".
After restarting firefox, everything is back to the way it was customized.


Expected results:

Nothing should get resized or moved.

Comment 1

[:Gijs (he/him)]

I can't reproduce this (on OS X, Firefox 39, at least).

Do you have any add-ons installed, or are you testing with a clean profile? If this wasn't a clean profile, can you check with a clean profile and post your about:support list of add-ons? Does it matter where the bookmarks toolbar bit ends up, and would you be OK with attaching a screenshot of your navigation toolbar before it gets collapsed into the overflow button?

Comment 2

[clej37]

Ok, sorry... This should have been the first thing to try... Didn't happen with a clean profile (in safe mode). This behavior seems to be caused by the "Colorfultabs" add-on. Should I report this to its developer ?

Comment 3

[:Gijs (he/him)]

(In reply to clej37 from comment #2)
> Ok, sorry... This should have been the first thing to try... Didn't happen
> with a clean profile (in safe mode). This behavior seems to be caused by the
> "Colorfultabs" add-on. Should I report this to its developer ?

I mean, that would be useful, but as one of the people who worked on the overflowable toolbar implementation I'd like to understand why it's happening better... maybe we can fix it on the Firefox end. I'll try to reproduce it after intalling that add-on later this week (hopefully tomorrow). Thanks for the quick response!

Comment 4

[:Gijs (he/him)]

(In reply to clej37 from comment #2)
> Ok, sorry... This should have been the first thing to try... Didn't happen
> with a clean profile (in safe mode). This behavior seems to be caused by the
> "Colorfultabs" add-on. Should I report this to its developer ?

OK, I'm very sorry that it's taken me so long to look into this further. I:

1) created a new profile on Linux
2) ran Firefox 41 nightly from a month ago or so
3) installed colorful tabs from addons.mozilla.org
4) restarted Firefox
5) opened a second tab, went to google.com
6) tried to drag either of the two tabs onto the location bar


I just see an insertion cursor in the url or search field, and otherwise things seem to work fine.

Maybe there are further settings in colorful tabs that trigger this? Or maybe the add-on got updated to fix it by now, because I was so slow... ? Are you still seeing this?

Comment 5

[clej37]

I tried again with a new profile in which I only installed ColorfulTabs. It was difficult to reproduce but I finally managed by moving either a tab or a bookmark back and forth above the limit between the address field and the bookmarks toolbar items (positioned on the left of the address field).

I think it also depends on the number of bookmarks. We can sometimes see bookmarks half-disapear below the button ">>" and the address field.

My firefox version is 39.0 (the last available in archlinux/stable).

Comment 6

[:Gijs (he/him)]

I suspect this was fixed by the changes in bug 1580538 and friends. Can someone confirm if they're still seeing this on Firefox 73 or later?

Comment 7

[:Gijs (he/him)]

Going to resolve this as I suspect it's fixed now.