RayGun fails to capture exceptions when stack trace locals have unicode

RESOLVED FIXED

Status

Webtools
Pontoon
P5
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: mkelly, Unassigned)

Tracking

Firefox Tracking Flags

(firefox42 affected)

Details

(Reporter)

Description

3 years ago
RayGun appears to call str() on all locals in a stack trace before sending an exception off to their server, which breaks when one of those locals are unicode and need to be encoded. We currently have RayGun disabled as a workaround.

I believe the solution would be to submit a PR to their Python library that casts the locals with unicode() instead of str(), but more testing of that is necessary.
(Reporter)

Comment 1

3 years ago
Someone already reported this to Raygun: https://github.com/MindscapeHQ/raygun4py/issues/23

I've submitted a PR to their library: https://github.com/MindscapeHQ/raygun4py/pull/24
Assignee: nobody → mkelly

Comment 2

3 years ago
Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/0a491ff77aeea8b121d4288e746995ccec785ec9
Bug 1179963: Re-enable raygun and use fork.

Re-enables Raygun and temporarily uses my fork of raygun4py with a fix
for our unicode issues. Once the fix gets merged we should switch back
to the official library.
Priority: -- → P5
(Reporter)

Updated

3 years ago
Assignee: mkelly → nobody
(Reporter)

Comment 3

3 years ago
Only remaining step here is to switch back to using the default RayGun library once our two current PRs are merged upstream.

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.