1179993 - debug.peformancedata.shared should be debug.performance_data.shared in common-settings.json

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Martijn Wargers (dead)]

At:
http://mxr.mozilla.org/gaia/source/build/config/common-settings.json#65
I see:   "debug.peformancedata.shared": false,

This should be 65    "debug.performance_data.shared": false,

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1179993 > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8630004 [details] [review]
[gaia] mwargers:1179993 > mozilla-b2g:master

LGTM, thanks!

Comment 3

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/a75733f0a0b305dcd03cf8d11533136ac1c05b7b

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] mozilla-b2g:revert-30841-1179993 > mozilla-b2g:master

Comment 5

[Martijn Wargers (dead)]

Sorry, I had to revert this, because there is a test failure in make_test.js: https://treeherder.mozilla.org/logviewer.html#?job_id=1588977&repo=gaia
I would also need to fix that, before this can be merged.

Comment 6

[Martijn Wargers (dead)]

I guess this the pref is true in settings.json, because of this line:
http://mxr.mozilla.org/gaia/source/build/settings.js#260

I guess according to bug 1134445, comment 4 (it was developed in bug 1109422), the debug.performance_data.shared value has to be actually true in settings.json.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1179993_2 > mozilla-b2g:master

Comment 8

[Martijn Wargers (dead)]

Comment on attachment 8630221 [details] [review]
[gaia] mwargers:1179993_2 > mozilla-b2g:master

Sorry, again review. This pref should actually be true by default, as it appears. See bug 1134445, comment 4 and further.

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8630221 [details] [review]
[gaia] mwargers:1179993_2 > mozilla-b2g:master

This seems fine, thanks.

Comment 10

[Martijn Wargers (dead)]

Everything was green now on Try, so merged: https://github.com/mozilla-b2g/gaia/commit/4aa0bf3673b9240a0eebe1e56a5f66b00becc2b3