Closed
Bug 1179993
Opened 10 years ago
Closed 10 years ago
debug.peformancedata.shared should be debug.performance_data.shared in common-settings.json
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: martijn.martijn, Assigned: martijn.martijn)
References
()
Details
Attachments
(3 files)
At:
http://mxr.mozilla.org/gaia/source/build/config/common-settings.json#65
I see: "debug.peformancedata.shared": false,
This should be 65 "debug.performance_data.shared": false,
|
||
Comment 1•10 years ago
|
||
|
Assignee | |
Updated•10 years ago
|
Attachment #8630004 -
Flags: review?(kgrandon)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8630004 [details] [review]
[gaia] mwargers:1179993 > mozilla-b2g:master
LGTM, thanks!
Attachment #8630004 -
Flags: review?(kgrandon) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•10 years ago
|
||
|
|
Assignee | |
Comment 5•10 years ago
|
||
Sorry, I had to revert this, because there is a test failure in make_test.js: https://treeherder.mozilla.org/logviewer.html#?job_id=1588977&repo=gaia
I would also need to fix that, before this can be merged.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 6•10 years ago
|
||
I guess this the pref is true in settings.json, because of this line:
http://mxr.mozilla.org/gaia/source/build/settings.js#260
I guess according to bug 1134445, comment 4 (it was developed in bug 1109422), the debug.performance_data.shared value has to be actually true in settings.json.
|
|
||
Comment 7•10 years ago
|
||
|
|
Assignee | |
Comment 8•10 years ago
|
||
Comment on attachment 8630221 [details] [review]
[gaia] mwargers:1179993_2 > mozilla-b2g:master
Sorry, again review. This pref should actually be true by default, as it appears. See bug 1134445, comment 4 and further.
Attachment #8630221 -
Flags: review?(kgrandon)
|
|
||
Comment 9•10 years ago
|
||
Comment on attachment 8630221 [details] [review]
[gaia] mwargers:1179993_2 > mozilla-b2g:master
This seems fine, thanks.
Attachment #8630221 -
Flags: review?(kgrandon) → review+
|
|
Assignee | |
Comment 10•10 years ago
|
||
Everything was green now on Try, so merged: https://github.com/mozilla-b2g/gaia/commit/4aa0bf3673b9240a0eebe1e56a5f66b00becc2b3
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•