1180017 - Make GCCellPtr easier to use with new opaque type decls

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Now that we need external type decls for all TraceKinds anyway for CallbackTracer, we might as well make use of them in GCCellPtr to simplify the definitions and make it more useful internally (and potentially externally too, since it is used by CallbackTracer). Specifically, we should move MapTypeToTraceKind external and use that to implement GCCellPtr::is<T> and as<T>. This would get rid of the isFoo()/asFoo() method explosion.

Comment 1

[Jim Blandy :jimb]

Attachment: Give GCCellPtr is<T> and to<T> methods, replacing isFoo and toFoo methods. Fix callers.

Perhaps this goes too far?

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 8629534 [details] [diff] [review]
Give GCCellPtr is<T> and to<T> methods, replacing isFoo and toFoo methods. Fix callers.

Review of attachment 8629534 [details] [diff] [review]:
-----------------------------------------------------------------

Having worked with those tools for a couple months, I'm happy with them. Might as well take it to its logical conclusion: these are exactly the tools we want, so let's just make it so.

Comment 3

[Jim Blandy :jimb]

<jimb> terrence: For consistency within SpiderMonkey, I would like to have the extraction method named as<T>, instead of to<T>. Is that okay with you?
<terrence> jimb: yes, that's fine

Comment 4

[Jim Blandy :jimb]

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e986173481ef

Comment 5

[Jim Blandy :jimb]

Dumb build issue; new Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=12ea8194a61e

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/465793bc6fcf

Comment 7

[Carsten Book [:Tomcat]]

sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b65c048414f7 since one of this changes might have caused bug 1188799 at least started with this pushes

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dde3457426b9

Comment 9

[Carsten Book [:Tomcat]]

and re-checkedin since this turned out to be innocent. sorry Jim :(

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6873269bc49

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dde3457426b9
https://hg.mozilla.org/mozilla-central/rev/b6873269bc49