1180036 - ~7,500 instances of 'WARNING: anonymous nodes should not be in child lists (bug 439258)' emitted from layout/base/RestyleManager.cpp during linux64 debug testing

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Eric Rahm [:erahm]]

> 7454 [NNNNN] WARNING: anonymous nodes should not be in child lists (bug 439258): file layout/base/RestyleManager.cpp, line 1448

This is currently the #3 most verbose warning [1] during linux64 debug testing. I imagine this relates to bug 1177819 as well.

Given bug 439258 has been around 7 years, perhaps we should give up on this warning?

[1] https://hg.mozilla.org/mozilla-central/annotate/f5e3bacfb60e/layout/base/RestyleManager.cpp#l1448

Comment 1

[Boris Zbarsky [:bzbarsky]]

I think we should use the infrastructure from bug 1177819 here as well to not warn in the cases that bug doesn't warn/assert in and see where that leaves us.

Comment 2

[Eric Rahm [:erahm]]

With the landing of bug 1177819 it looks like we can start work on this. Also this is now the #1 most verbose warning.

Comment 3

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d501bd1665ae

Comment 4

[Eric Rahm [:erahm]]

Attachment: Replace the warning that anonymous nodes should not be in child lists with an assert plus whitelisting of known-OK cases

The try run indicates bug 1177819 covered all the whitelisting cases. All we need to do is switch to an assert w/ whitelisting here.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8638604 [details] [diff] [review]
Replace the warning that anonymous nodes should not be in child lists with an assert plus whitelisting of known-OK cases

r=me

Comment 6

[Eric Rahm [:erahm]]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/cc03e18f0438a92863e8871fdffe8efa52c9f4a6
changeset:  cc03e18f0438a92863e8871fdffe8efa52c9f4a6
user:       Eric Rahm <[e-mail]>
date:       Fri Jul 24 09:47:51 2015 -0700
description:
Bug 1180036 - Replace the warning that anonymous nodes should not be in child lists with an assert plus whitelisting of known-OK cases. r=bz

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cc03e18f0438