All users were logged out of Bugzilla on October 13th, 2018
I noticed this in this HTML report: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/848/HTML_Report/ This was an adhoc run to test out the pull request for bug 1177553. It turns out something in the code changed that makes this locator fail, the change was done in bug 1177800. So we need to fix the locators here. Traceback (most recent call last): File "/var/jenkins/1/workspace/flame-kk.ui.adhoc/.env/local/lib/python2.7/site-packages/marionette_client-0.16-py2.7.egg/marionette/marionette_test.py", line 296, in run testMethod() File "/var/jenkins/1/workspace/flame-kk.ui.adhoc/tests/python/gaia-ui-tests/gaiatest/tests/functional/cost_control/test_cost_control_data_alert_mobile.py", line 37, in test_cost_control_data_alert_mobile settings.toggle_data_alert_switch(True) File "/var/jenkins/1/workspace/flame-kk.ui.adhoc/tests/python/gaia-ui-tests/gaiatest/apps/cost_control/regions/settings.py", line 45, in toggle_data_alert_switch switch = self.marionette.find_element(*self._data_alert_switch_locator) File "/var/jenkins/1/workspace/flame-kk.ui.adhoc/.env/local/lib/python2.7/site-packages/marionette_driver-0.9-py2.7.egg/marionette_driver/marionette.py", line 1589, in find_element response = self._send_message('findElement', 'value', **kwargs) File "/var/jenkins/1/workspace/flame-kk.ui.adhoc/.env/local/lib/python2.7/site-packages/marionette_driver-0.9-py2.7.egg/marionette_driver/decorators.py", line 36, in _ return func(*args, **kwargs) File "/var/jenkins/1/workspace/flame-kk.ui.adhoc/.env/local/lib/python2.7/site-packages/marionette_driver-0.9-py2.7.egg/marionette_driver/marionette.py", line 715, in _send_message self._handle_error(response) File "/var/jenkins/1/workspace/flame-kk.ui.adhoc/.env/local/lib/python2.7/site-packages/marionette_driver-0.9-py2.7.egg/marionette_driver/marionette.py", line 751, in _handle_error raise errors.lookup(status)(message, stacktrace=stacktrace) NoSuchElementException: NoSuchElementException: Unable to locate element: input[data-option="dataLimit"]
Created attachment 8629181 [details] [review] https://github.com/mozilla-b2g/gaia/pull/30812 This makes the test pass again.
Thanks for fixing these, and sorry about the breakage. There's likely more to come if treeherder isn't catching these. Let me know if there's anything I can do to make your lives easier.
No problem Kevin. This is sort of the normal situation, because developers don't look at the Jenkins results of the Gaia UI tests (and why should they, they should only look at Treeherder). The only thing you could do is run those tests yourself, locally or kick off a Jenkins try run. Or you could ask me to do that if you suspect something will break on the Gaia UI tests. I think the plan is to remove Gaia UI tests completely from Treeherder, so that would diminish visibility of these tests even more.
Comment on attachment 8629181 [details] [review] https://github.com/mozilla-b2g/gaia/pull/30812 Everything looks good to me!
Attachment #8629181 - Flags: review?(jlorenzo) → review+
Comment on attachment 8629181 [details] [review] https://github.com/mozilla-b2g/gaia/pull/30812 looks fine to me too.
Attachment #8629181 - Flags: review?(npark) → review+
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.