1180073 - The per-bug details page should display the time not just the date

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect, P2)

Description

[Ed Morley [:emorley]]

Since without bug comments it becomes more important to tell at what time of day the failures occurred, if reviewing those that occurred today.

We should also make it clear whether the time/date is for the start-time, end-time, or classification-time.

Comment 1

[Ed Morley [:emorley]]

Plus also which timezone - but that's bug 807273, and may require more than just UI changes.

Comment 2

[Ed Morley [:emorley]]

Attachment: Part 1: Clean up the API time related fields

The 'timestamp' key in the API response was previously just duplicating 'date':
        {
          "platform": "b2g-device-image",
          "test": "[TC] B2G Flame KK Eng",
          "starttime": "1435679299",
          "branch": "b2g-inbound",
          "buildtype": "opt",
          "date": "2015-06-30",
          "timestamp": "2015-06-30",
          "machinename": "unknown",
          "bug": "1126945",
          "revision": "f4c00adda27c"
        },

Nothing was using it, so it has been removed, and instead replaced by a more
clearly named "classification_time", which is what Treeherder is putting into
the 'timestamp' property of the ElasticSearch document.

Also adds a comment about the inconsistency of 'date' (ie it's job scheduled
date, not job start date).

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8629370 [details] [diff] [review]
Part 1: Clean up the API time related fields

Review of attachment 8629370 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8629370 [details] [diff] [review]
Part 1: Clean up the API time related fields

https://hg.mozilla.org/automation/orangefactor/rev/f351bcc5b723

Comment 5

[Ed Morley [:emorley]]

Attachment: Part 2: Display the job start time in the UI, rather than just the date

Previously for each failure instance shown on the "single bug detail page", only the job submit *date* was shown, and not also the time. The UI now uses "starttime" to be able to display the time as well. However this is the job *start* time, rather than when the job was scheduled. As such, this is missing on any jobs that were classified whilst they were still in the pending state (though these are pretty rare, from inspection of the raw ES data).

Ideally we'd re-work the data submission from Treeherder entirely, but it's neither worth the effort, nor going to see immediate benefits (since we'd still be missing fields/times for old data in ES).

We're using the JS moments library, since date handling in JS is awful. See:
http://momentjs.com/docs/#/parsing/unix-timestamp/
http://momentjs.com/docs/#/parsing/utc/
http://momentjs.com/docs/#/displaying/format/

Comment 6

[Ed Morley [:emorley]]

Attachment: Screenshot of new start time column

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 8657882 [details] [diff] [review]
Part 2: Display the job start time in the UI, rather than just the date

Forgot to set the review flag on this the other day; see comment 5 for the patch details, and comment 6 for the screenshot :-)

Comment 8

[Ed Morley [:emorley]]

Comment on attachment 8657882 [details] [diff] [review]
Part 2: Display the job start time in the UI, rather than just the date

https://hg.mozilla.org/automation/orangefactor/rev/f7a627bcb6d6

+ deployed :-)