Convert TestPLDHash.cpp to a gtest

RESOLVED FIXED in Firefox 42

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
gtest seems to be the direction we're moving towards, and it certainly makes
this test more compact, reducing its length by 86 lines.
(Assignee)

Comment 1

3 years ago
Created attachment 8629191 [details] [diff] [review]
Convert TestPLDHash.cpp to a gtest
Attachment #8629191 - Flags: review?(nfroyd)
(Assignee)

Comment 2

3 years ago
Hmm, maybe this should go in xpcom/glue/tests/gtest/ rather than xpcom/tests/gtest/?
Personally, I think it is better to avoid more subdirectories when possible. I have a vague sense that glue/ vs base/ is more about the linkage of stuff which I wouldn't think would really apply to a gtest.
Comment on attachment 8629191 [details] [diff] [review]
Convert TestPLDHash.cpp to a gtest

Review of attachment 8629191 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.  Is this going to get in the way of your "try to test edge cases from a child process" work elsewhere?
Attachment #8629191 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 5

3 years ago
(In reply to Nathan Froyd [:froydnj] [:nfroyd] from comment #4)
>
> Sure.  Is this going to get in the way of your "try to test edge cases from
> a child process" work elsewhere?

Hopefully not. What little testing of the edge case stuff I've done has been on top of this gtest patch.
https://hg.mozilla.org/mozilla-central/rev/40740cddc131
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.