1180084 - Convert TestPLDHash.cpp to a gtest

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

gtest seems to be the direction we're moving towards, and it certainly makes
this test more compact, reducing its length by 86 lines.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Convert TestPLDHash.cpp to a gtest

Comment 2

[Nicholas Nethercote [inactive]]

Hmm, maybe this should go in xpcom/glue/tests/gtest/ rather than xpcom/tests/gtest/?

Comment 3

[Andrew McCreight [:mccr8]]

Personally, I think it is better to avoid more subdirectories when possible. I have a vague sense that glue/ vs base/ is more about the linkage of stuff which I wouldn't think would really apply to a gtest.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8629191 [details] [diff] [review]
Convert TestPLDHash.cpp to a gtest

Review of attachment 8629191 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.  Is this going to get in the way of your "try to test edge cases from a child process" work elsewhere?

Comment 5

[Nicholas Nethercote [inactive]]

(In reply to Nathan Froyd [:froydnj] [:nfroyd] from comment #4)
>
> Sure.  Is this going to get in the way of your "try to test edge cases from
> a child process" work elsewhere?

Hopefully not. What little testing of the edge case stuff I've done has been on top of this gtest patch.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/40740cddc131

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/40740cddc131