118010 - Non-latin1 recipient is displayed garbled when picked up from address picker

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect)

Description

[ji]

******Observed with 01/03 trunk build****

After selecting a Ja address book card and clicking on Compose button, the Ja
recipient name appears garbled on new mail compose window.

Steps to reproduce:
1. Have a Japanese card in the address book.
2. Select the Japanese card and click on Compose window. You can see the Ja
recipients are garbled.

Or
1. Open a new mail compose window.
2. Click on Address button
3. Select a Japanese card and click on To: button, the Ja recipient name is
garbled on the list.

Comment 1

[marina]

all recipients that are non-latin1 are displayed garbled through the Address picker.

Comment 2

[ji]

Changed the summary based on Marina's comments.

Comment 3

[ji]

It doesn't happen on 12/21 trunk build.

Comment 4

[nhottanscp]

Cc to putterman, sspitzer. Could this be related to the outliner change or
something else?

Comment 5

[nhottanscp]

I installed builds 12/21 and 12/22, the problem started from 12/22 build.

Comment 6

[nhottanscp]

There were many changes on 12/21 to mailnews/addrbook directory for the outliner
change. Seth, any idea which file I should look at?

Comment 7

[nhottanscp]

abCommon.js calls nsIMsgHeaderParser::MakeFullAddress, this function uses UTF-8
for input and output. This is not scriptable because JavaScript cannot handle UTF-8.
We need to change nsIMsgHeaderParser to make current functions to noscript and
add new functions which take PRUnichar*. Or change not to use MakeFullAddress.
How this was handled before the outliner change?

Comment 8

[nhottanscp]

Attachment: Added wstring version of MakeFullAddress, changed non wstring functions to noscript because they need UTF-8 string.

Comment 9

[Jean-Francois Ducarroz]

Comment on attachment 64203 [details] [diff] [review]
Added wstring version of MakeFullAddress, changed non wstring functions to noscript because they need UTF-8 string.

R=ducarroz

Comment 10

[nhottanscp]

*** Bug 119119 has been marked as a duplicate of this bug. ***

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 64203 [details] [diff] [review]
Added wstring version of MakeFullAddress, changed non wstring functions to noscript because they need UTF-8 string.

methods in idl should be in interCaps.

ParseHeaderAddresses() should be

parseHeaderAddresses()

this should be a simple change, since they are all noscript (meaning you won't
have to fix any JS)

except for MakeFullAddressWString().

when you make it makeFullAddressWString()

don't forget to fix abCommon.js

once you do that, sr=sspitzer

Comment 12

[nhottanscp]

ParseHeadersWithArray() is used in msgHdrViewOverlay.js, so that needs the
change too.

Comment 13

[nhottanscp]

Attachment: Changed function names as sspitzer's comment.

Comment 14

[nhottanscp]

checked in

Comment 15

[ji]

Verified as fixed with 01/14 trunk builds.