Closed
Bug 1180106
Opened 10 years ago
Closed 10 years ago
Hamburger menu attempts to fetch a profile when no user is logged in
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 42
People
(Reporter: markh, Assigned: markh)
References
Details
Attachments
(1 file)
1.34 KB,
patch
|
eoger
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8629215 -
Flags: review?(edouard.oger)
Comment 1•10 years ago
|
||
Comment on attachment 8629215 [details] [diff] [review]
0003-Bug-XXXXXXX-don-t-attempt-to-fetch-an-FxA-user-profi.patch
Review of attachment 8629215 [details] [diff] [review]:
-----------------------------------------------------------------
Forgot about this. Looks good though!
Attachment #8629215 -
Flags: review+
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Updated•10 years ago
|
Attachment #8629215 -
Flags: review?(edouard.oger) → review-
Updated•10 years ago
|
Attachment #8629215 -
Flags: review-
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8629215 [details] [diff] [review]
0003-Bug-XXXXXXX-don-t-attempt-to-fetch-an-FxA-user-profi.patch
Approval Request Comment
[Feature/regressing bug #]: 1139698
[User impact if declined]: Errors in the console
[Describe test coverage new/current, TreeHerder]: Existing tests pass
[Risks and why]: None
[String/UUID change made/needed]: None
Attachment #8629215 -
Flags: approval-mozilla-aurora?
status-firefox41:
--- → affected
Comment on attachment 8629215 [details] [diff] [review]
0003-Bug-XXXXXXX-don-t-attempt-to-fetch-an-FxA-user-profi.patch
Approved. one-line fix that has been in m-c for a while. Safe to uplift to Aurora.
Attachment #8629215 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 6•10 years ago
|
||
Updated•10 years ago
|
QA Contact: catalin.varga
You need to log in
before you can comment on or make changes to this bug.
Description
•