1180106 - Hamburger menu attempts to fetch a profile when no user is logged in

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0003-Bug-XXXXXXX-don-t-attempt-to-fetch-an-FxA-user-profi.patch

Comment 1

[Edouard Oger [:eoger]]

Comment on attachment 8629215 [details] [diff] [review]
0003-Bug-XXXXXXX-don-t-attempt-to-fetch-an-FxA-user-profi.patch

Review of attachment 8629215 [details] [diff] [review]:
-----------------------------------------------------------------

Forgot about this. Looks good though!

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4b0bbbe52830

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4b0bbbe52830

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8629215 [details] [diff] [review]
0003-Bug-XXXXXXX-don-t-attempt-to-fetch-an-FxA-user-profi.patch

Approval Request Comment
[Feature/regressing bug #]: 1139698
[User impact if declined]: Errors in the console
[Describe test coverage new/current, TreeHerder]: Existing tests pass
[Risks and why]: None
[String/UUID change made/needed]: None

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8629215 [details] [diff] [review]
0003-Bug-XXXXXXX-don-t-attempt-to-fetch-an-FxA-user-profi.patch

Approved. one-line fix that has been in m-c for a while. Safe to uplift to Aurora.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/703050be92f3