Closed Bug 1180130 Opened 9 years ago Closed 9 years ago

[Stingray] Scaffolding Device Deck

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dwi2, Assigned: dwi2)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

[gaia] dwi2:bug1180130 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review 
Create basic part of Device Deck, includes:
1. UI without actual device connectivity
2. Able to navigate using key
Blocks: 1074080
No longer depends on: 1074080
Blocks: 1180154
Blocks: 1180156
Assignee: nobody → tzhuang
Blocks: 1180158
Status: NEW → ASSIGNED
Depends on: 1182990
Depends on 1182990 because some device icons are incorrect.
Comment on attachment 8632679 [details] [review]
[gaia] dwi2:bug1180130 > mozilla-b2g:master

Hi Rex,

Please help to review the patch. This patch is basic structure of device deck without any real functionality.
Attachment #8632679 - Flags: review?(rexboy)
Comment on attachment 8632679 [details] [review]
[gaia] dwi2:bug1180130 > mozilla-b2g:master

Looks good.
Just some css issue. See my comment on Github.
Attachment #8632679 - Flags: review?(rexboy) → review+
Thanks. All comments are addressed.

Gaia-try result
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=495b4b75f1d2f9963665eabe129aab576e1dc720

Landed in master
https://github.com/mozilla-b2g/gaia/commit/82bbf7acb527f7ebf818e9b9d55692ef48ad895e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 1189251
Blocks: 1189249
Blocks: 1194620
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: