1180205 - Disable Unified Complete in Firefox 41

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P1)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Unified complete is currently enabled in Aurora.

Considered the first feature taking good benefits from it is search suggestions, and those are only enabled in Firefox 42 (bug 958204).
Also considering the fact we still have regression (bug 1176437, bug 1172937, bug 1047613) that we are working on right now.

I feel like the benefit in keeping the feature enabled in Aurora is not enough vs the price to keep it up to date with nightly by uplifiting patches and tracking all the changes.
I think we should release it along with search suggestions, or in the version where most regressions will be fixed. Releasing a non-top quality awesomebar experience should be a no-go.

However, I'd be fine doing this disabling closer to the Beta merge, so we get more Aurora testing.

Comment 1

[Dave Townsend [:mossop]]

Yeah this makes sense

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1

https://treeherder.mozilla.org/#/jobs?repo=try&revision=94fed337de68

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8631477 [details] [diff] [review]
patch v1

ok, the failures don't look related to this.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8631477 [details] [diff] [review]
patch v1

Approval Request Comment
[Feature/regressing bug #]: unified complete
[User impact if declined]: the feature is not on-par with quality to ride the trains to release
[Describe test coverage new/current, TreeHerder]: unit tests
[Risks and why]: no risk, just reverting to the old component
[String/UUID change made/needed]: none

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

This should only land in Aurora.

Comment 6

[Kate Glazko]

Comment on attachment 8631477 [details] [diff] [review]
patch v1

Approving uplift to Aurora because low risk, only backing out.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7f732682a8ec