Closed
Bug 1180246
Opened 9 years ago
Closed 9 years ago
Thebes and Layers use our obsolete custom cairo_d2d_surface extension which is superceded by Moz2D
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: lsalzman, Assigned: lsalzman)
Details
Attachments
(4 files)
7.74 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
4.62 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
6.46 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
12.24 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
gfxD2DSurface in Thebes used our cairo_d2d_surface extensions, and unnecessarily ties us to our customized version of Cairo. This prevents us from one day migrating back to upstream Cairo. We should just remove it.
Assignee | ||
Comment 1•9 years ago
|
||
This patch removes any places using gfxD2DSurface, since Moz2D ensures this code was already dead.
Attachment #8629423 -
Flags: review?(bas)
Assignee | ||
Comment 2•9 years ago
|
||
Kill the files now, because we can.
Attachment #8629424 -
Flags: review?(bas)
Assignee | ||
Comment 3•9 years ago
|
||
Remove any dependencies on cairo_d2d_device functions to set up our D3D10 device, since the gfxWindowsPlatform code and Factory in Moz2D are already doing the necessary work.
Attachment #8629425 -
Flags: review?(bas)
Assignee | ||
Comment 4•9 years ago
|
||
TextureClientD3D9 had a lot of obsolete code to interoperate with Cairo which was literally not being used anywhere anymore and is completely safe to remove. This way we are only left with a minimal dependency on Cairo there inside gfxWindowsSurface, which uses our cairo_win32_surface_create_with_d3dsurface9 extension (though that will eventually have to be excised somehow).
Attachment #8629426 -
Flags: review?(bas)
Assignee | ||
Comment 5•9 years ago
|
||
Green try run for all these changes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fda36420bc0
Comment 6•9 years ago
|
||
Comment on attachment 8629423 [details] [diff] [review] part 1 - remove dependencies on gfxD2DSurfcae Review of attachment 8629423 [details] [diff] [review]: ----------------------------------------------------------------- This is really happy making.
Attachment #8629423 -
Flags: review?(bas) → review+
Comment 7•9 years ago
|
||
Comment on attachment 8629424 [details] [diff] [review] part 2 - Kill gfxD2DSurface with fire Review of attachment 8629424 [details] [diff] [review]: ----------------------------------------------------------------- I'm feeling filled with joy.
Attachment #8629424 -
Flags: review?(bas) → review+
Comment 8•9 years ago
|
||
Comment on attachment 8629425 [details] [diff] [review] part 3 - remove usage of cairo_d2d_device Review of attachment 8629425 [details] [diff] [review]: ----------------------------------------------------------------- Does the joy know no end?
Attachment #8629425 -
Flags: review?(bas) → review+
Comment 9•9 years ago
|
||
Comment on attachment 8629426 [details] [diff] [review] part 4 - reduce Cairo dependencies where safe in TextureClientD3D9 Review of attachment 8629426 [details] [diff] [review]: ----------------------------------------------------------------- I wonder if this texture client is ever used anyway..
Attachment #8629426 -
Flags: review?(bas) → review+
Assignee | ||
Comment 10•9 years ago
|
||
Did one more try run just to verify the oranges were intermittents: https://treeherder.mozilla.org/#/jobs?repo=try&revision=25c17783e1c4
Keywords: checkin-needed
Comment 11•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c57bb7808cd1 https://hg.mozilla.org/integration/mozilla-inbound/rev/72b010271780 https://hg.mozilla.org/integration/mozilla-inbound/rev/032749270f86 https://hg.mozilla.org/integration/mozilla-inbound/rev/a04ce0f96418
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c57bb7808cd1 https://hg.mozilla.org/mozilla-central/rev/72b010271780 https://hg.mozilla.org/mozilla-central/rev/032749270f86 https://hg.mozilla.org/mozilla-central/rev/a04ce0f96418
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•