1180418 - Search terms aren't escaped

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Richard Newman [:rnewman]]

Type "AT&T". Search. Observe that the string appears literally in the url, and thus the search is for "AT".

Comment 1

[Karim Benhmida [:karim]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/682

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8630615 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/682

It looks like this still allows other characters that should be encoded, such as "+" and "?".

Rather than starting with all valid query characters and blacklisting specific ones, I'd create a whitelist from the ground up that includes only allowable characters.

According to Wikipedia [1]: Letters (A–Z and a–z), numbers (0–9) and the characters '*','-','.' and '_' are left as-is. All other characters are encoded.

So how about we create a custom character set with just those characters?

[1] https://en.wikipedia.org/wiki/Query_string#URL_encoding

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8630615 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/682

r=me with hardcoded string extracted.

Comment 4

[Karim Benhmida [:karim]]

Comment on attachment 8630615 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/682

Harcoded string extracted. r=bnicholson

Comment 5

[Karim Benhmida [:karim]]

Commit 2634ae35ebfef39e7f45abb81ac087b24f02d066