Topic system message is duplicated on joining a room

RESOLVED FIXED in Instantbird 42

Status

defect
--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aleth, Assigned: abdelrahman)

Tracking

({regression})

trunk
Instantbird 42

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
23:09:29 - The topic for devel@conference.pidgin.im is: Pidgin, Finch, and libpurple development headquarters.
23:09:29 - rekkanoryo has set the subject to: Pidgin, Finch, and libpurple development headquarters

Could do without one or the other system message.
(Assignee)

Comment 1

4 years ago
Assignee: nobody → a.ahmed1026
Status: NEW → ASSIGNED
Attachment #8633822 - Flags: review?(aleth)
(Reporter)

Comment 2

4 years ago
Comment on attachment 8633822 [details] [diff] [review]
rev 1 - avoid duplicating topic system message

Review of attachment 8633822 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/protocols/xmpp/xmpp.jsm
@@ +1379,5 @@
>        // TODO There can be multiple subject elements with different xml:lang
>        // attributes.
>        muc.setTopic(subject.innerText, nick);
>      }
> +    else if (body) {

You can just return early after setTopic instead, as receiving a subject shouldn't really trigger typing notifications.
Attachment #8633822 - Flags: review?(aleth) → review-
(Assignee)

Comment 3

4 years ago
Attachment #8633822 - Attachment is obsolete: true
Attachment #8634023 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/3487a322b28d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
Updating milestone from 1.6 to 42.
Target Milestone: 1.6 → Instantbird 42
You need to log in before you can comment on or make changes to this bug.