1180464 - Reword Install button with free or price

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

STR:
1. Open any app listing in zh-TW locale, say https://marketplace.firefox.com/app/drag-race-3d
2. Check the wording for install button.

Actual:
售價 免費 元 (Price: Free dollars) look weird in Chinese
(Original text is "Install for {price}", the action is implied by price in translation)

Expected:
If the app is free of charge, it should simply show "Free" (免費) or "Free Install" (免費安裝) on the button. The current string, "Install for {price}" (售價 {price} 元) should be used separately, only when the app is selling for a price.

Comment 1

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Hi Peiying, I think you might also understand this issue?

Comment 2

[Peiying Mo [:CocoMo]]

Hi Peter,

Totally agree with you on this. However, when I check the source string on the Fireplace module in Verbatim, it looks like the correct string was submitted 7 weeks ago. When I checked the Github site, it looks like the code push from Verbatim to Github was 5 days ago.  It has the correction there. The code push to production is on Tuesdays. This should be fixed then.

Make sure every time you make changes in Verbatim, you click on the link of Commit to All VCS or changes in Verbatim be pushed to Github.

Let's check again on Wednesday. If it is still incorrect, let's reopen the bug.

Thanks,
Peiying

Comment 3

[Po-chiang Chao [:bobchao]]

Hi Peiying,

I don't really think that this is a l10n issue -- more like an i18n issue?

https://github.com/mozilla/fireplace/blob/4cadb7b51e600e427d59a884f889ca418c29bed0/src/media/js/buttons.js#L428-L429

Comment 4

[Ton [:Tonnes]]

This bug only got my attention after filing bug 1180839. It looks like separate strings are a better option.

Comment 5

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Please correct me if I'm wrong but consider the action of button, I don't think this is an issue at l10n side as well. It seems this bug was introduced 7 weeks ago, and the l10n for this problematic message was committed at May 21st - see  https://github.com/mozilla/fireplace/commit/f197fd20ede5663db98bfef5d4cd8e42811dba07 , not too long after then.

Didn't check if this was already fixed on master, but there's another merge problem preventing pull or commit right now on Verbatim. Let's wait.

Comment 6

[Peiying Mo [:CocoMo]]

Hi Matjaz, could you check why Peter has trouble merging the changes on Verbatim. The change related to the bug is fixed from what I can see.  But he has other merge issue.

Comment 7

[Matjaz Horvat [:mathjazz]]

This is what caused the merge conflict:
https://github.com/mozilla/fireplace/commit/c7bc17f96bca250f22d3a07bcadf19854d487450

Fixed.

Comment 8

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Attachment: Screenshot

Apparently the bug still exists.

Comment 9

[Mark Striemer [:mstriemer]]

The strings have been split into "Install for free" and "Install for {price}" since bug 1180839. Unfortunately I encountered an error when extracting the new strings as our usual string-extractor was away. I forgot to run the extraction last week so this is unfortunately going to have to wait another week.

I'm going to take this bug so that it stays on my todo list but this should be fixed the next time we run a Verbatim extraction.

Comment 10

[David Durst [:ddurst]]

It sounds like this request actually runs counter to what we decided to do -- and implemented last week. Marking as uiwanted, but I'm hesitant to revisit this issue.

NI to Peiying -- the change to "Install for {price}" and "Install for free" as separate strings was a request stemming from localization as well. Not sure if there's a perfect answer for this.

Comment 11

[Peiying Mo [:CocoMo]]

This impacts more than one language. It needs to be fixed.

Comment 12

[David Durst [:ddurst]]

OK, but it's not clear to me what needs to be fixed.

We used to have "Install for ____" and ___ was either {price} or "free" (localized).

That was suggested to be changed to be "Install for {price}" and "Install for free", each localizable. There was an error in the string extraction in the last week of July, but if I'm not mistaken, this should be fixed by last week's extraction (which should be visible in today's push).

If we're not talking about a specific error and rather a suggestion of a different change to localizable strings, I'm not clear on what needs to be fixed.

Comment 13

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

I can confirm it's fixed for "free" now, but couldn't find an app that is sold for price yet?

Comment 14

[Ton [:Tonnes]]

Peter, does https://marketplace.firefox.com/app/misstake/?src=desktop-promo show a paid app for you? And when you’re at it, could you also check the position of your currency symbol (bug 1185250)?

To developers: this may sound a bit grumpy, but I’d strongly advise to make up your mind about what should be shown and in what format for once and for all, keeping in mind l18n, maybe looking at some other parties. Needless to say it’s a little annoying to see several bugs about these strings, time (months) and energy spent in them, as well as things like extraction errors and the l10n process itself leading up to delay. After all, proper initial design rules are half the work and should minimize issues afterwards.

Personally I’m not fond of "Install for free" and would rather just see "Install" (as most apps are free) and use e.g. "Install (price)" for paid apps only, considering they’re exceptional, which would also take up less space and minimize l18n impact. (In fact I left this "workaround" in for our locale because I think it looks better than using "for" anyway.) If mentioning "free" is a prerequisite, "Install (free)" might be the other option. One could even think of using different button colors for paid and free apps, where a price or "free" could be shown somehwere else than on (but near) the button, or "free" could be left out in that case. Just a thought.

Comment 15

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

(In reply to Ton from comment #14)
> Peter, does https://marketplace.firefox.com/app/misstake/?src=desktop-promo
> show a paid app for you? And when you’re at it, could you also check the

That looks good for me, marking this bug as fixed. 

> position of your currency symbol (bug 1185250)?

It shows US$19.99 here, which is not "localized" to the currency used in zh-TW locale (Mostly TWD or NT$ ?) so Bug 1185250 is not applicable to zh-TW locale for now IMO.
 
> To developers: this may sound a bit grumpy, but I’d strongly advise to make
> up your mind about what should be shown and in what format for once and for
> all, keeping in mind l18n, maybe looking at some other parties. Needless to
> say it’s a little annoying to see several bugs about these strings, time
> (months) and energy spent in them, as well as things like extraction errors
> and the l10n process itself leading up to delay. After all, proper initial
> design rules are half the work and should minimize issues afterwards.
> 
> Personally I’m not fond of "Install for free" and would rather just see
> "Install" (as most apps are free) and use e.g. "Install (price)" for paid
> apps only, considering they’re exceptional, which would also take up less
> space and minimize l18n impact. (In fact I left this "workaround" in for our
> locale because I think it looks better than using "for" anyway.) If
> mentioning "free" is a prerequisite, "Install (free)" might be the other
> option. One could even think of using different button colors for paid and
> free apps, where a price or "free" could be shown somehwere else than on
> (but near) the button, or "free" could be left out in that case. Just a
> thought.

+1 to this, but I guess there might be even some locales can not fit in this way? Maybe we could have a wiki or guideline for such formats Mozilla-wide.

Comment 16

[Peiying Mo [:CocoMo]]

Here is a guide written by someone well known in the industry: http://www.xencraft.com/resources/multi-currency.html