Closed Bug 1180481 Opened 8 years ago Closed 8 years ago

Remove aero from the tree. Part 3 (messenger)

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
All
Windows
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 42.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 2 obsolete files)

No-messenger-aero.patch
16.33 KB, patch
Paenglab
: review+
Details | Diff | Splinter Review 
Remove messenger-aero.css
Attached patch No-messenger-aero.patch (obsolete) — — Splinter Review 
Remove messenger-aero.css. This patch needs bug 1180475 applied first.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8629643 - Flags: review?(bwinton)
Attached patch No-messenger-aero.patch (obsolete) — — Splinter Review 
Found a not correctly indented part.
Attachment #8629643 - Attachment is obsolete: true
Attachment #8629643 - Flags: review?(bwinton)
Attachment #8632425 - Flags: review?(bwinton)
Comment on attachment 8632425 [details] [diff] [review]
No-messenger-aero.patch

Blake has ho possibility to review this patch for a couple of weeks. Changing to Philipp.
Attachment #8632425 - Flags: review?(bwinton) → review?(philipp)
Comment on attachment 8632425 [details] [diff] [review]
No-messenger-aero.patch

Review of attachment 8632425 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp with comments considered:

::: mail/themes/windows/mail/messenger.css
@@ +231,5 @@
> +
> +  #tabmail-buttons > toolbarbutton {
> +    margin-top: 3px;
> +    margin-bottom: 0;
> +  }

There are the same rules in the other block describing winxp. Maybe it makes sense to put these rules into the common block, and then overwrite them on the older windows version instead?

There may also be some other rules like this I missed.
Attachment #8632425 - Flags: review?(philipp) → review+
Updated the commit message to r=Fallen

(In reply to Philipp Kewisch [:Fallen] from comment #4)
> Comment on attachment 8632425 [details] [diff] [review]
> No-messenger-aero.patch
> 
> Review of attachment 8632425 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=philipp with comments considered:
> 
> ::: mail/themes/windows/mail/messenger.css
> @@ +231,5 @@
> > +
> > +  #tabmail-buttons > toolbarbutton {
> > +    margin-top: 3px;
> > +    margin-bottom: 0;
> > +  }
> 
> There are the same rules in the other block describing winxp. Maybe it makes
> sense to put these rules into the common block, and then overwrite them on
> the older windows version instead?
> 
> There may also be some other rules like this I missed.

Moved the possible non-XP rules to common and let the XP rules overwrite them.
Attachment #8632425 - Attachment is obsolete: true
Attachment #8644271 - Flags: review+
Keywords: checkin-needed
url:        https://hg.mozilla.org/comm-central/rev/a7e8b30f993a55e84d7776123be7e6b90a254663
changeset:  a7e8b30f993a55e84d7776123be7e6b90a254663
user:       Richard Marti <richard.marti@gmail.com>
date:       Thu Aug 06 12:36:18 2015 +0200
description:
Bug 1180481 - Get rid of messenger-aero.css. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 42.0
You need to log in before you can comment on or make changes to this bug.