Closed Bug 1180505 Opened 9 years ago Closed 9 years ago

[settings]notification should use switcher instead of checker

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog)

Status:
RESOLVED FIXED
Project Flags:
tracking-b2g backlog

People

(Reporter: gasolin, Assigned: gasolin)

Details

(Keywords: foxfood, Whiteboard: [bzlite])

Attachments

(2 files)

2015-07-05-22-39-24.png
37.05 KB, image/png
Details
[gaia] gasolin:issue-1180505 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yzen
: review+
Details | Review 
User-Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

it strange that sibling panels use different ui pattern.
notification use checker but navigation use switcher
Attached image 2015-07-05-22-39-24.png — 
Component: Gaia::Feedback → Gaia::Settings

    
    

    
  
Is there a guideline when should we use a switch or a checkbox?
Flags: needinfo?(thsieh)

    
    

    
  
Here is the guideline of switches: 
https://developer.mozilla.org/en-US/Apps/Design/Firefox_OS_building_blocks/Switches

It should be toggles (switches) because those lists aren't closely related. Please replace the checkboxes into toggles, thanks!
Flags: needinfo?(thsieh)

    
  

          tracking-b2g:
          --- → backlog

    
  
Assignee: nobody → gasolin

    
    

    
  
Comment on attachment 8668830 [details] [review]
[gaia] gasolin:issue-1180505 > mozilla-b2g:master

treeherder green, please take it a look

        Attachment #8668830 -
        Flags: review?(yzenevich)

    
    

    
  
Comment on attachment 8668830 [details] [review]
[gaia] gasolin:issue-1180505 > mozilla-b2g:master

Looks good, thanks!

        Attachment #8668830 -
        Flags: review?(yzenevich) → review+

    
    

    
  
merged https://github.com/mozilla-b2g/gaia/commit/e0845653d282daf6a79e427de5cbae9400ceb346

thanks!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: