1180508 - test_smime_mimemsg_representation.js fails due to missing data files from db-tinderbox-invalid

Status: RESOLVED WORKSFORME

(MailNews Core :: Security: S/MIME, defect)

Description

[:aceman]

Running the test mailnews/db/gloda/test/unit/test_smime_mimemsg_representation.js via mach I get an error:

0:02.62 LOG: Thread-1 ERROR [initNSS : 25] tbird-bin/_tests/xpcshell/mailnews/data/db-tinderbox-invalid does not exist
0:02.62 LOG: Thread-1 ERROR NS_ERROR_FILE_TARGET_DOES_NOT_EXIST: Component returned failure code: 0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST) [nsIFile.copyTo]
initNSS@tbird-bin/_tests/xpcshell/mailnews/db/gloda/test/unit/test_smime_mimemsg_representation.js:29:5
run_test@tbird-bin/_tests/xpcshell/mailnews/db/gloda/test/unit/test_smime_mimemsg_representation.js:91:3
_execute_test@TB-hg/mozilla/testing/xpcshell/head.js:508:7
0:02.76 TEST_END: Thread-1 FAIL, expected PASS

The needed files do exist in tree/mailnews/test/data/db-tinderbox-invalid but are not copied to the test directory at tbird-bin/_tests/xpcshell/mailnews/data/ .
Seems to be a build problem. Did the test really work at the time bug 1152287 was fixed? Or did the build system change?

The Makefile contains:
ifdef ENABLE_TESTS
libs::
$(DIR_INSTALL) $(wildcard $(srcdir)/test/data/*) $(MOZDEPTH)/_tests/xpcshell/mailnews/data

Maybe it no longer copies subfolders?

According to bug 1152287 the test went also into TB38. Does it work there correctly?

Comment 1

[Suyash Agarwal (:sshagarwal)]

I can confirm this. I see the same error on running this test.

Thanks.

Comment 2

[Joshua Cranmer [:jcranmer]]

This only fails if you use mach xpcshell-tests. What happens is the test files are installed via a Makefile.in rule, but mach runs a make command to process test installation manifests, which deletes the directory since it's not in the manifest.

Comment 3

[Joshua Cranmer [:jcranmer]]

This should be fixed since we started using TEST_HARNESS_FILES.