Closed
Bug 118051
Opened 23 years ago
Closed 23 years ago
oiddata.h is installed in dist/private but is included by the public header file nsspki1.h
Categories
(NSS :: Build, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
3.4
People
(Reporter: wtc, Assigned: bugz)
Details
oiddata.h is installed in mozilla/dist/private/security because it is listed in PRIVATE_EXPORTS in mozilla/security/nss/lib/pki1/manifest.mn. But oiddata.h is included by the public header file nsspki1.h, which in turn is included by nsspki.h. This problem can be solved in two ways. 1. If nsspki1.h does not need to include oiddata.h, we can remove the inclusion of oiddata.h from nsspki1.h. 2. If nsspki1.h must include oiddata.h, we should list oiddata.h in EXPORTS instead of PRIVATE_EXPORTS so that it is installed in mozilla/dist/public/security. Ian, Bob, what is the right solution?
Reporter | ||
Updated•23 years ago
|
Priority: -- → P1
Target Milestone: --- → 3.4
Version: 3.0 → 3.4
Assignee | ||
Comment 1•23 years ago
|
||
I think the correct solution is to remove pki1 from the builds entirely and defer the problem to 4.0. The only reason pki1 is being built is that pki has some references to types defined in pki1, though AFAIK there is no implementation being used. So the pki1 types could be "faked" in pki for now and save us some headache.
Reporter | ||
Comment 2•23 years ago
|
||
Ian, that sounds good to me, but do we need to export nsspki.h in NSS 3.4? If we don't, we can also avoid this problem in 3.4 by listing nsspki.h, nsspki1.h, and oiddata.h in PRIVATE_EXPORTS.
Assignee | ||
Comment 3•23 years ago
|
||
done.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 4•23 years ago
|
||
Ian, did you fix this by removing pki1 from the builds entirely and "faking" the pki1 types in pki?
Assignee | ||
Comment 5•23 years ago
|
||
No, I made the headers private exports. I decided that was best, since no one needs to see those headers in 3.4 anyway.
You need to log in
before you can comment on or make changes to this bug.
Description
•