1180522 - Fix timezone alias for Buenos Aires

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[[:MakeMyDay]]

Based on the analysis of bug 1165396, timezone alias for "Argentina Standard Time" resolves to "America/Buenos_Aires", while the zone definition only has only "America/Argentina/Buenos_Aires", which is also the correct tzid.

Comment 1

[[:MakeMyDay]]

Attachment: FixTZAliasBuonesAires-V1.diff

This patch changes the aliasTo "America/Argentina/Buenos_Aires" and adds another alias for "America/Buenos_Aires".

Furthermore, a test is added to check consistency of aliases and zone definitions. Fot this I made the alias list available from the tz service.

The test passes, see http://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/[e-mail]-83c7e498986e/try-comm-central-win32/try-comm-central_xp-ix_test-xpcshell-bm110-tests1-windows-build1.txt.gz

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8629703 [details] [diff] [review]
FixTZAliasBuonesAires-V1.diff

Review of attachment 8629703 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, r=philipp

Just an idle thought I had while reviewing this, maybe we could generate zones.json at build time from the files in http://mxr.mozilla.org/comm-central/source/mozilla/intl/icu/source/data/misc/ specifically zoneinfo64.txt.

This way we could defer timezone updates to the Toolkit folks.

Comment 3

[[:MakeMyDay]]

Bug 1181304 filed for the automated creation of zones.json

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset dc4ac52c50ca