Closed
Bug 1180534
Opened 10 years ago
Closed 10 years ago
Convert developer HUD controls to web components
Categories
(Firefox OS Graveyard :: Developer Tools, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
Details
Attachments
(1 file)
In preparation for moving to web components we should port the controls to use gaia-checkbox and gaia-switch.
|
||
Comment 1•10 years ago
|
||
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8629718 [details] [review]
[gaia] KevinGrandon:bug_1180534_developer_hud_controls > mozilla-b2g:master
Alex, or Evelyn - This code is fairly specific to the developer tools inside of gaia, and normally I would ask Arthur or Janx for a review, but they seem to be off right now. Could either of you take a look? Thanks!
Attachment #8629718 -
Flags: review?(poirot.alex)
Attachment #8629718 -
Flags: review?(ehung)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8629718 [details] [review]
[gaia] KevinGrandon:bug_1180534_developer_hud_controls > mozilla-b2g:master
LGTM. Thanks!
Attachment #8629718 -
Flags: review?(ehung) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8629718 [details] [review]
[gaia] KevinGrandon:bug_1180534_developer_hud_controls > mozilla-b2g:master
Thank you Evelyn!
Attachment #8629718 -
Flags: review?(poirot.alex)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•10 years ago
|
||
I've landed a follow-up to address the colors missing: https://github.com/mozilla-b2g/gaia/commit/bf234318b1383a68d5fb9bd5ef76203ee1669c39
You need to log in
before you can comment on or make changes to this bug.
Description
•