Closed Bug 1180534 Opened 9 years ago Closed 9 years ago

Convert developer HUD controls to web components

Categories

(Firefox OS Graveyard :: Developer Tools, defect)

Product:
Firefox OS Graveyard
Component:
Developer Tools
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

Details

Attachments

(1 file)

[gaia] KevinGrandon:bug_1180534_developer_hud_controls > mozilla-b2g:master
46 bytes, text/x-github-pull-request
jj.evelyn
: review+
Details | Review 
In preparation for moving to web components we should port the controls to use  gaia-checkbox and gaia-switch.
Comment on attachment 8629718 [details] [review]
[gaia] KevinGrandon:bug_1180534_developer_hud_controls > mozilla-b2g:master

Alex, or Evelyn - This code is fairly specific to the developer tools inside of gaia, and normally I would ask Arthur or Janx for a review, but they seem to be off right now. Could either of you take a look? Thanks!
Attachment #8629718 - Flags: review?(poirot.alex)
Attachment #8629718 - Flags: review?(ehung)
Comment on attachment 8629718 [details] [review]
[gaia] KevinGrandon:bug_1180534_developer_hud_controls > mozilla-b2g:master

LGTM. Thanks!
Attachment #8629718 - Flags: review?(ehung) → review+
Comment on attachment 8629718 [details] [review]
[gaia] KevinGrandon:bug_1180534_developer_hud_controls > mozilla-b2g:master

Thank you Evelyn!
Attachment #8629718 - Flags: review?(poirot.alex)
In master: https://github.com/mozilla-b2g/gaia/commit/6f4c21bb027f034043a6b41bfcb8541dfda7a22e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Depends on: 1185285
No longer depends on: 1185285
I've landed a follow-up to address the colors missing: https://github.com/mozilla-b2g/gaia/commit/bf234318b1383a68d5fb9bd5ef76203ee1669c39
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: