enable fontconfig platform fontlist for release builds

RESOLVED FIXED in Firefox 44, Firefox OS v2.5

Status

()

Core
Graphics: Text
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: jtd, Assigned: jtd)

Tracking

(Depends on: 3 bugs)

Trunk
mozilla45
Unspecified
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 wontfix, firefox44 fixed, firefox45 fixed, b2g-v2.5 fixed, relnote-firefox 44+)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The use of the new fontconfig platform fontlist code is currently behind a pref that is only enabled for nightly/dev builds but not for beta/release builds. Until we switch to this code, we cannot enable 'unicode-range' across all platforms.
(Assignee)

Updated

3 years ago
Depends on: 1182361
(Assignee)

Updated

3 years ago
Depends on: 1173260
(Assignee)

Comment 1

3 years ago
Created attachment 8689289 [details] [diff] [review]
patch, enable fontconfig platform fontlist for release builds

Once the patches on bug 1224965 land, we should be okay to enable fontconfig platform fontlist on release builds.
Attachment #8689289 - Flags: review?(karlt)
(Assignee)

Updated

3 years ago
Depends on: 1224965
Comment on attachment 8689289 [details] [diff] [review]
patch, enable fontconfig platform fontlist for release builds

>-#ifdef RELEASE_BUILD
>-pref("gfx.font_rendering.fontconfig.fontlist.enabled", false);
>-#else
> pref("gfx.font_rendering.fontconfig.fontlist.enabled", true);
> #endif

Need to remove the balancing #endif.

Cameron has been reviewing some of this code, so asking whether he's happy that what he has seen is ready.
Attachment #8689289 - Flags: review?(karlt)
Attachment #8689289 - Flags: review?(cam)
Attachment #8689289 - Flags: review+
Comment on attachment 8689289 [details] [diff] [review]
patch, enable fontconfig platform fontlist for release builds

Review of attachment 8689289 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I think it's ready to to let this ride to Beta.  If any more weird distro font configurations are out there they probably won't be noticed until we get this to more users.
Attachment #8689289 - Flags: review?(cam) → review+
(Assignee)

Comment 4

3 years ago
Karl, thanks for all your help with this work!

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/08a4d2e0ad79
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
(Assignee)

Comment 7

3 years ago
Comment on attachment 8689289 [details] [diff] [review]
patch, enable fontconfig platform fontlist for release builds

Approval Request Comment
[Feature/regressing bug #]: This bug blocks enabling unicode-range for beta/release builds. Enabling the new fontconfig back end will allow us to release unicode-range support across all platforms (bug 1119062).
[User impact if declined]: unicode-range support can't be enabled until FF45
[Describe test coverage new/current, TreeHerder]: landed on trunk last week, no issues reported
[Risks and why]: new fontconfig font backend has been enabled for nightly/aurora for several release cycles now and all known regressions have been resolved
[String/UUID change made/needed]: none
Attachment #8689289 - Flags: approval-mozilla-aurora?

Updated

3 years ago
status-firefox44: --- → affected

Comment 8

3 years ago
Comment on attachment 8689289 [details] [diff] [review]
patch, enable fontconfig platform fontlist for release builds

Aurora44+
Attachment #8689289 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 9

3 years ago
Jtd, should we add this to 44 release notes?
Flags: needinfo?(jdaggett)
(Assignee)

Comment 10

3 years ago
(In reply to Ritu Kothari (:ritu) from comment #9)
> Jtd, should we add this to 44 release notes?

Yes, that would be a good idea!
Flags: needinfo?(jdaggett)
(Assignee)

Comment 11

3 years ago
Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/f6ecc28fba3d
status-firefox42: affected → wontfix
status-firefox44: affected → fixed
(In reply to John Daggett (:jtd) from comment #10)
> (In reply to Ritu Kothari (:ritu) from comment #9)
> > Jtd, should we add this to 44 release notes?
> 
> Yes, that would be a good idea!

In that case, would you be able to provide suggested wording? Are there any blogs/links that the relnote should include? If you can set relnote-firefox tracking flag to "?" and fill out the template, that would be extremely helpful. Thanks.
relnote-firefox: --- → ?
Flags: needinfo?(jdaggett)
(Assignee)

Comment 14

3 years ago
Release Note Request (optional, but appreciated)
[Why is this notable]: font matching under Linux has changed

[Suggested wording]: To support the unicode-range descriptor for webfonts, font matching under Linux now uses the same font matching code shared with other platforms. On Linux, this code uses fontconfig for platform font family lookups so font substitutions will still work. But in some cases complex font substitution rules may no longer work as they did before. Please file a bug if you run into a problem with Firefox not respecting a given fontconfig configuration.

[Links (documentation, blog post, etc)]: https://bugzilla.mozilla.org/show_bug.cgi?id=1056479
Flags: needinfo?(jdaggett)
Depends on: 1231713
Suggested wording from comment 14 trimmed down to one sentence (release notes need to be short) and added to Beta44 release notes.

"To support unicode-range descriptor for webfonts, font matching under Linux uses the same font matching code as other platforms."
relnote-firefox: ? → 44+
(Assignee)

Comment 16

3 years ago
(In reply to Ritu Kothari (:ritu) from comment #15)
> Suggested wording from comment 14 trimmed down to one sentence (release
> notes need to be short) and added to Beta44 release notes.
> 
> "To support unicode-range descriptor for webfonts, font matching under Linux
> uses the same font matching code as other platforms."

Ok, sounds good!
(Assignee)

Updated

3 years ago
No longer depends on: 1231713
FWIW, I just got a report from a friend that this change makes his Firefox fail to pick the proper Chinese serif font on Linux. He also mentioned that he had rather complicated fontconfig setting, so he had no idea whether there was any combination of his config causes this. [1]

[1] https://twitter.com/hexcles/status/692118226982010881 (Chinese)
(Assignee)

Comment 18

2 years ago
(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #17)
> FWIW, I just got a report from a friend that this change makes his Firefox
> fail to pick the proper Chinese serif font on Linux. He also mentioned that
> he had rather complicated fontconfig setting, so he had no idea whether
> there was any combination of his config causes this. [1]
> 
> [1] https://twitter.com/hexcles/status/692118226982010881 (Chinese)

Thanks for forwarding this but could you file a new bug and attach details? It would be helpful to have a copy of whatever fontconfig settings the user has. I'm guessing it wouldn't be too hard to work around but it depends upon how complex the logic they're using in their fontconfig settings.

Comment 19

2 years ago
Thanks :xidorn and :jtd.

I've filed BUG 1243226 for this issue.
Depends on: 1243073
Depends on: 1243157
Depends on: 1244212
Depends on: 1243194
Depends on: 1249973

Updated

2 years ago
Depends on: 1245804
Depends on: 1254245
Depends on: 1269187
You need to log in before you can comment on or make changes to this bug.