Closed Bug 1180574 Opened 9 years ago Closed 9 years ago

Intermittent test_fullscreen-api-race.html | The window should no longer be in fullscreen

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Version:
38 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox41 --- unaffected
firefox42 --- fixed
firefox43 --- fixed
firefox-esr38 --- unaffected

People

(Reporter: philor, Assigned: xidorn)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

disable specific subtest on Linux 32bit
1.71 KB, patch
philor
: review+
Details | Diff | Splinter Review
MozReview Request: Bug 1180574 - Retry once if we open a window in fullscreen mode in fullscree-api-race test.
40 bytes, text/x-review-board-request
smaug
: review+
Details 
      No description provided.
Doesn't seem to be going all that well.
Blocks: 1179123
Flags: needinfo?(quanxunzhen)
I tend to remove the specific subtest which causes this...
Flags: needinfo?(quanxunzhen)
I currently don't have any Linux 32bit platform installed... So let's disable the specific subtest for now.
Attachment #8630326 - Flags: review?(philringnalda)
Comment on attachment 8630326 [details] [diff] [review]
disable specific subtest on Linux 32bit

I wouldn't have guess that as a successful way to identify linux32, but if it works it works.
Attachment #8630326 - Flags: review?(philringnalda) → review+
Keywords: leave-open
See Also: → 1181446
The new intermittent (on Linux 32bit) are on subtest openNewWindow, exitFullscreen, different from the previous disabled subtest.
The intermittent on Linux 64bit is the subtest I previously disabled on Linux 32bit. I probably can try to fix that now. But for the new intermittent on Linux 32bit, I tend to disable the specific subtest again.
It seems this intermittent happens because the new window is sometimes opened in fullscreen mode.
So this happens because when the new window is open, its parent window haven't exited from fullscreen, and the new window restores the persisted XUL window attributes which makes it enter fullscreen mode.

It indicates that my patch for bug 1137009 could fix this issue, because that patch stops persisting window attributes when we enter fullscreen for Fullscreen API.

Alternatively, we can make the test wait until the main window actually back to normal before continuing.
My try push in comment 242 should fix most of this bug (compare the push in comment 242 and comment 241). However, it seems there is one additional different issue which could generate the same failure signature here. I think that issue should be in a different bug, though.

I'll open one when we mark this bug as fixed.
Depends on: 1137009
Bug 1180574 - Retry once if we open a window in fullscreen mode in fullscree-api-race test.
Attachment #8649594 - Flags: review?(bugs)
Assignee: nobody → quanxunzhen
Keywords: leave-open
Attachment #8649594 - Flags: review?(bugs) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/69518fb59017ae6337103ac2686b81c1ecd41e7a
changeset:  69518fb59017ae6337103ac2686b81c1ecd41e7a
user:       Xidorn Quan <quanxunzhen@gmail.com>
date:       Fri Aug 21 09:17:18 2015 +1000
description:
Bug 1180574 - Retry once if we open a window in fullscreen mode in fullscree-api-race test. r=smaug
https://hg.mozilla.org/mozilla-central/rev/69518fb59017
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Blocks: 1197642
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: