Last Comment Bug 1180588 - Spinner size is wrong on retina computer (when manually entering details for new account)
: Spinner size is wrong on retina computer (when manually entering details for ...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: unspecified
: Unspecified Mac OS X
-- normal (vote)
: Thunderbird 42.0
Assigned To: Richard Marti (:Paenglab)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-07-06 00:55 PDT by Soledad Penades [:sole] [:spenades]
Modified: 2015-08-07 13:56 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Screenshot 2015-07-06 08.49.35.png (12.94 KB, image/png)
2015-07-06 00:55 PDT, Soledad Penades [:sole] [:spenades]
no flags Details
retinaSpinner.patch (979 bytes, patch)
2015-07-06 11:15 PDT, Richard Marti (:Paenglab)
bwinton: review+
Details | Diff | Splinter Review
retinaSpinner.patch (976 bytes, patch)
2015-07-09 08:46 PDT, Richard Marti (:Paenglab)
richard.marti: review+
Details | Diff | Splinter Review

Description User image Soledad Penades [:sole] [:spenades] 2015-07-06 00:55:12 PDT
Created attachment 8629827 [details]
Screenshot 2015-07-06 08.49.35.png

See attachment - the spinner is wrongly sized and also not aligned to anything in particular.

It's not P1 but it does look ugly. Maybe a good first bug depending on how complex the layout is? :-)
Comment 1 User image Richard Marti (:Paenglab) 2015-07-06 11:15:45 PDT
Created attachment 8630071 [details] [diff] [review]
retinaSpinner.patch

Blake, sorry to flood you with reviews.

This is a one liner. I have no Retina Mac to test and tested the functionality with other images but it should work.
Comment 2 User image Blake Winton (:bwinton) (:☕️) 2015-07-09 07:27:46 PDT
Comment on attachment 8630071 [details] [diff] [review]
retinaSpinner.patch

I think that line should be in the non-retina version, since we want it to be the same size for both…
But aside from that, r=me.
Comment 3 User image Richard Marti (:Paenglab) 2015-07-09 08:46:50 PDT
Created attachment 8631632 [details] [diff] [review]
retinaSpinner.patch

Comment addressed.
Comment 4 User image aleth [:aleth] 2015-08-07 13:54:23 PDT
url:        https://hg.mozilla.org/comm-central/rev/14bce500986370c97b7a0bf6dd17057ca6ee2c1f
changeset:  14bce500986370c97b7a0bf6dd17057ca6ee2c1f
user:       Richard Marti <richard.marti@gmail.com>
date:       Thu Jul 09 17:43:06 2015 +0200
description:
Bug 1180588 - Fix the spinner size for Retina displays in new account window. r=bwinton

Note You need to log in before you can comment on or make changes to this bug.