Spinner size is wrong on retina computer (when manually entering details for new account)

RESOLVED FIXED in Thunderbird 42.0

Status

Thunderbird
Theme
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sole, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 42.0
Unspecified
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 8629827 [details]
Screenshot 2015-07-06 08.49.35.png

See attachment - the spinner is wrongly sized and also not aligned to anything in particular.

It's not P1 but it does look ugly. Maybe a good first bug depending on how complex the layout is? :-)
Component: Account Manager → Theme
OS: Unspecified → Mac OS X
(Assignee)

Comment 1

2 years ago
Created attachment 8630071 [details] [diff] [review]
retinaSpinner.patch

Blake, sorry to flood you with reviews.

This is a one liner. I have no Retina Mac to test and tested the functionality with other images but it should work.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8630071 - Flags: review?(bwinton)
Comment on attachment 8630071 [details] [diff] [review]
retinaSpinner.patch

I think that line should be in the non-retina version, since we want it to be the same size for both…
But aside from that, r=me.
Attachment #8630071 - Flags: review?(bwinton) → review+
(Assignee)

Comment 3

2 years ago
Created attachment 8631632 [details] [diff] [review]
retinaSpinner.patch

Comment addressed.
Attachment #8630071 - Attachment is obsolete: true
Attachment #8631632 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
url:        https://hg.mozilla.org/comm-central/rev/14bce500986370c97b7a0bf6dd17057ca6ee2c1f
changeset:  14bce500986370c97b7a0bf6dd17057ca6ee2c1f
user:       Richard Marti <richard.marti@gmail.com>
date:       Thu Jul 09 17:43:06 2015 +0200
description:
Bug 1180588 - Fix the spinner size for Retina displays in new account window. r=bwinton

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 42.0
You need to log in before you can comment on or make changes to this bug.