1180607 - Remove pre-v2.x keyboard settings migration

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Make sense to do this as we decided to wontfix bug 1109451.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

WIP https://github.com/timdream/gaia/tree/input-mgmt-migration

I will work on other bugs first...

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Per discussion on dev-fxos.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] timdream:input-mgmt-remove-migration > mozilla-b2g:master

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] raylin:input-mgmt-remove-migration > mozilla-b2g:master

Comment 5

[Ray Lin[:ralin]]

Comment on attachment 8715119 [details] [review]
[gaia] raylin:input-mgmt-remove-migration > mozilla-b2g:master

Hi, Alberto

This is the follow-up bug of Bug 1184342.

It seems the failed tested won't be solved in the near future, however, this patch is done and good, I think we should finish it. Could you please help to review it? Thank you :)

Comment 6

[Alberto Pastor [:albertopq]]

Hey Ray, could you please rebase it first to make it easier to check the specific changes?Thanks!

Comment 7

[Ray Lin[:ralin]]

Oops, sorry about that, PR is rebased now. Please help me to check it again, thanks!

Comment 8

[Alberto Pastor [:albertopq]]

The code looks good to me, but can you double check that the Gij10 failure [1] is not caused by this patch?
Thanks!

[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=72bcda22c8d1cd4822bbebaf2e6ba74f4c4f8f8b&selectedJob=3522041

Comment 9

[Ray Lin[:ralin]]

The cause of the error is intermittent fail again... :( I think we can handle it in another bug. Thanks.

Comment 10

[Alberto Pastor [:albertopq]]

The question here is if the intermittent is caused by this patch or was already there. If it was already there, of course, we can handle that in a different bug. Just asking because Gij10 is related to the Keyboard. Thanks!

Comment 11

[Ray Lin[:ralin]]

Sorry I did not make it clear, the intermittent is not related to this patch. Thanks!

Comment 12

[Alberto Pastor [:albertopq]]

Comment on attachment 8715119 [details] [review]
[gaia] raylin:input-mgmt-remove-migration > mozilla-b2g:master

Thanks!

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/5b90c09648798d8d66c4b08f81402b27acf0dc08

Please remember to update the bug when you merge code!