Closed Bug 1180642 Opened 10 years ago Closed 10 years ago

[Control Center] Close identity panel when a keyboard-initiated action would blur it

Categories

(Firefox :: General, defect, P1)

Product:
Firefox
Component:
General
Type:
defect
Points:
3

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 42
Iteration:
42.1 - Jul 13
Tracking Flags:
Tracking Status
firefox41 + verified
firefox42 + verified

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

(Whiteboard: [fxprivacy] [campaign])

Attachments

(1 file)

0001-Bug-1180642-Control-Center-Close-panel-when-an-eleme.patch
2.55 KB, patch
Gijs
: review+
kglazko
: approval-mozilla-aurora+
Details | Diff | Splinter Review
[Tracking Requested - why for this release]: We used to close the identity panel when hitting Cmd+T to open a new tab, Cmd+W to close the current tab, or Cmd+Digit to switch between tabs. We broke this with bug 1146269 and will have to find a new way to solve this.
Flags: qe-verify+
Flags: firefox-backlog+
Rank: 1
I tried using Node.contains() but that doesn't seem to work for XUL/XBL. Listening for when another element receives focus seems to cover all of the cases where we want to close the panel, including tab switching, adding a tab, closing a tab, focusing the url bar, etc.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8630410 - Flags: review?(gijskruitbosch+bugs)
Iteration: --- → 42.1 - Jul 13
Blocks: 1168883
QA Contact: mwobensmith
Tracking for 41, 42 because affected.
tracking-firefox41: ? → +
tracking-firefox42: --- → +
Comment on attachment 8630410 [details] [diff] [review] 0001-Bug-1180642-Control-Center-Close-panel-when-an-eleme.patch Review of attachment 8630410 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8630410 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/9a607079f868
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment on attachment 8630410 [details] [diff] [review] 0001-Bug-1180642-Control-Center-Close-panel-when-an-eleme.patch Approval Request Comment [Feature/regressing bug #]: bug 1146269 [User impact if declined]: Identity panel stays open when hitting keyboard shortcuts like Cmd+T/W/N, etc. [Describe test coverage new/current, TreeHerder]: None. [Risks and why]: Low risk. [String/UUID change made/needed]: None.
Attachment #8630410 - Flags: approval-mozilla-aurora?
Depends on: 1182643
Comment on attachment 8630410 [details] [diff] [review] 0001-Bug-1180642-Control-Center-Close-panel-when-an-eleme.patch Low-risk, baked on m-c for 2 days.
Attachment #8630410 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Let's hold off uplifting this until we fixed bug 1182643.
Depends on: 1182872
Should uplift together with bug 1182643.
Whiteboard: [fxprivacy] → [fxprivacy] [campaign]
Verified as fixed using: FF 42 Build Id: 20150811030206 FF 41 Build Id: 20150810004008 OS: Win 7 x64, Ubuntu 12.04 x86, Mac Os X 10.10.4
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
status-firefox42: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: