1180657 - After booting, the screen goes black and Gaia never starts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Adrian Crespo]

Attachment: ADB logcat

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20150704030210

Steps to reproduce:

I have compiled a v3.0 and v2.2 full build for the Geeksphone Keon. I'm not sure if it is related to the bug.

Serial: full_keon (State: device)
Build ID               20150706015025
Gaia Revision          dc6c18c0dea7af3c40bfff86c530fd877d899dc4
Gaia Date              2015-07-04 01:35:20
Gecko Revision         4d5dc30f0f4a8a8dc5c75013b9f7641dbd15ab8c
Gecko Version          42.0a1
Device Name            keon
Firmware(Release)      4.0.4.0.4.0.4
Firmware(Incremental)  eng.firefox.20150706.013009
Firmware Date          Mon Jul  6 01:48:29 PDT 2015


Actual results:

After booting, the screen goes black and Gaia never starts: https://www.youtube.com/watch?v=71CJYW7YAN8

I have access with adb shell.

Comment 1

[Adrian Crespo]

Attachment: Standard output of the build proccess

Comment 2

[Adrian Crespo]

Attachment: Error output of the build process

Comment 3

[Adrian Crespo]

Please, check 1:36 in that video, notice tahat there are some random flashes.

Comment 4

[Helmar Gerloni]

Same here for Geeksphone Peak in master branch. Phone boots, but screen stays black. The error appeared around the 20 of June 2015. Build before worked well.

Comment 5

[Helmar Gerloni]

The commit causing the black screen is http://git.mozilla.org/?p=releases/gecko.git;a=commit;h=cfe9c42db44f0ffbfde3edc3430e788a78e5ad7a . When reverting the changes to GonkDisplayICS.cpp in the current B2G master tree the screen is OK again!

helmar@deb:~/Software/B2G$ diff gecko/widget/gonk/libdisplay/GonkDisplayICS.cpp.orig_2015-08-01 gecko/widget/gonk/libdisplay/GonkDisplayICS.cpp
171c171,178
<     return !mFBSurface->compositionComplete();
---
>     mFBSurface->compositionComplete();
> 
>     if (!mHwc) {
>         return true;
>     }
> 
>     mHwc->prepare(mHwc, nullptr);
>     return !mHwc->set(mHwc, dpy, sur, 0);

Maybe someone cound commit this "patch" an make a few Geeksphone users very happy ;-)

Helmar.

Comment 6

[leandro]

i can confirm helmar's solution works :D
thanks, Helmar

Comment 7

[Boris Chiou [:boris]]

(In reply to helmar from comment #5)
> The commit causing the black screen is
> http://git.mozilla.org/?p=releases/gecko.git;a=commit;
> h=cfe9c42db44f0ffbfde3edc3430e788a78e5ad7a . When reverting the changes to
> GonkDisplayICS.cpp in the current B2G master tree the screen is OK again!
> 
> helmar@deb:~/Software/B2G$ diff
> gecko/widget/gonk/libdisplay/GonkDisplayICS.cpp.orig_2015-08-01
> gecko/widget/gonk/libdisplay/GonkDisplayICS.cpp
> 171c171,178
> <     return !mFBSurface->compositionComplete();
> ---
> >     mFBSurface->compositionComplete();
> > 
> >     if (!mHwc) {
> >         return true;
> >     }
> > 
> >     mHwc->prepare(mHwc, nullptr);
> >     return !mHwc->set(mHwc, dpy, sur, 0);
> 
> Maybe someone cound commit this "patch" an make a few Geeksphone users very
> happy ;-)
> 
> Helmar.

OK, I can revert this part ASAP. Thanks for your checking.

Comment 8

[Boris Chiou [:boris]]

Attachment: Set EGL info while calling render() on ICS (v1)

Comment 9

[Boris Chiou [:boris]]

(In reply to leandro from comment #6)
> i can confirm helmar's solution works :D
> thanks, Helmar

Hi leandro,

Could you please apply the patch (attachment 8642233 [details] [diff] [review]) and verify again? I want to make sure this bug is caused by the missing EGL info. Thanks.

Comment 10

[Boris Chiou [:boris]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8875c24b4c0e

Comment 11

[leandro]

Hi Boris,
your patch works and the display boots, but it flicks a bit during the "based on mozilla technology" screen and (this is worse) during transtion  between screens (such as during the configuration wizard, or during the animation when opening an app from the homescreen).

During the scroll of the homescreen it flicks also, and the icons appear blurred.
I think you touched the problem, but there is still something wrong.

Don't know why, but i experienced the Helmar's solution without problems.



(In reply to Boris Chiou [:boris] from comment #9)
> (In reply to leandro from comment #6)
> > i can confirm helmar's solution works :D
> > thanks, Helmar
> 
> Hi leandro,
> 
> Could you please apply the patch (attachment 8642233 [details] [diff] [review]
> [review]) and verify again? I want to make sure this bug is caused by the
> missing EGL info. Thanks.

Comment 12

[Boris Chiou [:boris]]

Attachment: Use hwc directly on GonkDisplayICS swapbuffer

Comment 13

[Boris Chiou [:boris]]

(In reply to leandro from comment #11)
> Hi Boris,
> your patch works and the display boots, but it flicks a bit during the
> "based on mozilla technology" screen and (this is worse) during transtion 
> between screens (such as during the configuration wizard, or during the
> animation when opening an app from the homescreen).
> 
> During the scroll of the homescreen it flicks also, and the icons appear
> blurred.
> I think you touched the problem, but there is still something wrong.
> 
> Don't know why, but i experienced the Helmar's solution without problems.
> 
> 
> 
> (In reply to Boris Chiou [:boris] from comment #9)
> > (In reply to leandro from comment #6)
> > > i can confirm helmar's solution works :D
> > > thanks, Helmar
> > 
> > Hi leandro,
> > 
> > Could you please apply the patch (attachment 8642233 [details] [diff] [review]
> > [review]) and verify again? I want to make sure this bug is caused by the
> > missing EGL info. Thanks.

Thanks for your verfication. Let's back out this part.

Comment 14

[Boris Chiou [:boris]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=92622bc3189c

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/fec4e3434c44

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fec4e3434c44