1180664 - upgrade mozprofile from 0.23 to 0.25 in Talos

Status: RESOLVED DUPLICATE of bug 1190265

(Testing :: Talos, defect)

Description

[Julien Pagès (:parkouss)]

Origin of the issue: Bug 1173380 comment 10.

For me pip dependencies are working well, and installing talos in a fresh virtualenv install the right mozprofile (0.23). But still, we could update talos to use mozprofile 0.24.

Comment 1

[Julien Pagès (:parkouss)]

Attachment: 1180664.patch

Talos was relying on the fact that the cloned profile should not be deleted with the profile reference, but this was a mozprofile bug. In mozprofile 0.24 this is fixed, so this patch fix the usage of the clone function to explicitly ask to not auto delete the profile.

This patch can be applied directly, without the explicit requirement of mozprofile 0.24 because it should work with both versions.

This way we can take some more time to be sure that mozprofile 0.24 is available on the internal pypi required by Talos, and update the mozprofile version dependency of Talos to 0.24 (while we are here.. :)).

I can't land that to try right now, but I will be able to do that in a few hours I think. Joel, feel free to try/land if you prefer!

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

can we remove cache_flusher from requirements.txt as well :)

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8629940 [details] [diff] [review]
1180664.patch

Review of attachment 8629940 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!  feel free to land at your own convenience!

Comment 4

[Julien Pagès (:parkouss)]

Landed:

https://hg.mozilla.org/build/talos/rev/b4b41ebeec41

Comment 5

[Julien Pagès (:parkouss)]

Not a big deal but I did not checked my travis-ci build, so the last patch introduced a "line too long" issue: https://travis-ci.org/parkouss/build-talos/builds/69855134

Well I propose that the next patch here could:

- fix that line too long
- use mozprofile 0.24
- remove cache_flusher dependency

Comment 6

[Julien Pagès (:parkouss)]

So we should update to 0.25 now. the problem is that t is depending on mozlog 0.3.0, like a bunch of other mozbase packages that we will have to update.

Comment 7

[Julien Pagès (:parkouss)]

This will be done with bug 1190265.