Closed Bug 1180673 Opened 5 years ago Closed 5 years ago

Update about:healthreport URL for the new unified content

Categories

(Toolkit :: Telemetry, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla42
Iteration:
42.3 - Aug 10
Tracking Status
firefox40 --- wontfix
firefox41 --- verified
firefox42 --- verified

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

Details

(Whiteboard: [unifiedTelemetry] [uplift4])

Attachments

(2 files)

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Suggestion for implementation: Keep the current version exactly as is, and
> point the client at a new URL e.g. https://fhr.cdn.mozilla.net/v4/%LOCALE%/

I'm waiting for feedback on this in bug 1150491.
We also need to make sure that either the new content is up under that URL or at least the old one duplicated.
Whiteboard: [b5] [unifiedTelemetry] [uplift2]
Whiteboard: [b5] [unifiedTelemetry] [uplift2] → [rC] [unifiedTelemetry] [uplift3]
Whiteboard: [rC] [unifiedTelemetry] [uplift3] → [rC] [unifiedTelemetry] [uplift4]
Introducing a new pref allows us to keep manual testing and other use-cases sane. We can remove this and only use one again after we shipped unified Telemetry.
Attachment #8640510 - Flags: review?(benjamin)
Assignee: nobody → gfritzsche
Status: NEW → ASSIGNED
This actually flips the pref. We cant land this until the current remote content is duplicated under that URL.
Attachment #8640511 - Flags: review?(benjamin)
Attachment #8640510 - Flags: review?(benjamin) → review+
Attachment #8640511 - Flags: review?(benjamin) → review+
Simple copying of files to v4 directory in fhr-jelly: https://github.com/mozilla/fhr-jelly/pull/171
Keywords: leave-open
Comment on attachment 8640510 [details] [diff] [review]
Part 1 - Use a different URL pref for healthreport when Unified Telemetry is on and opt-out

Approval Request Comment
[Feature/regressing bug #]:
Telemetry Unification
[User impact if declined]:
This is a shipping requirement for Unified Telemetry. This adds a pref to override the URL we load the about:healthreport content from.
This patch doesn't change it yet, this happens in part 2 here which we will not land until the content is duplicated properly under the new URL.
It is part of a mostly fixup & diagnostic uplift batch for 41: http://bit.ly/1LYhA16
[Describe test coverage new/current, TreeHerder]:
We have automated test-coverage, have manually verified behavior, will do so again before landing on Aurora.
[Risks and why]:
Low-risk - this is a minimal change just adding an overriding URL pref. I'm not expecting any surprises here.
[String/UUID change made/needed]:
None.
Attachment #8640510 - Flags: approval-mozilla-aurora?
Whiteboard: [rC] [unifiedTelemetry] [uplift4] → [rC] [unifiedTelemetry] [uplift4] [uplift5]
Iteration: --- → 42.3 - Aug 10
Whiteboard: [rC] [unifiedTelemetry] [uplift4] [uplift5] → [unifiedTelemetry] [uplift4] [uplift5]
Depends on: 1192078
Attachment #8640510 - Flags: checkin+
Whiteboard: [unifiedTelemetry] [uplift4] [uplift5] → [unifiedTelemetry] [uplift4]
Comment on attachment 8640511 [details] [diff] [review]
Part 2 - Change the URL for the unified healthreport content to point to the v4 version

Approval Request Comment
[Feature/regressing bug #]:
Telemetry Unification
[User impact if declined]:
This is a shipping requirement for Unified Telemetry.
This part just changes the pref to point to the new v4 version for those users who have unified Telemetry on.
It is part of a mostly fixup & diagnostic uplift batch for 41: http://bit.ly/1LYhA16
[Describe test coverage new/current, TreeHerder]:
We have automated test-coverage, have manually verified behavior, will do so again before landing on Aurora.
[Risks and why]:
Low-risk - this just changes the pref to point to the new URL. I'm not expecting any surprises here and tested this manually before landing.
[String/UUID change made/needed]:
None.
Attachment #8640511 - Flags: approval-mozilla-aurora?
Attachment #8640511 - Flags: checkin+
Flags: qe-verify+
https://hg.mozilla.org/mozilla-central/rev/18299a261f36
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment on attachment 8640510 [details] [diff] [review]
Part 1 - Use a different URL pref for healthreport when Unified Telemetry is on and opt-out

[Triage Comment]

We need these as UT may be opt-in for FF41. Let's uplift to m-b.
Attachment #8640510 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
Comment on attachment 8640511 [details] [diff] [review]
Part 2 - Change the URL for the unified healthreport content to point to the v4 version

[Triage Comment]
Beta+
Attachment #8640511 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
Verified on 41.0b8 that 'datareporting.healthreport.about.reportUrlUnified' pref has the proper https://fhr.cdn.mozilla.net/%LOCALE%/v4/ value in about:config and about:healthreport page is correctly displayed. Is it enough to call this fix verified or something else needs to be checked here? Thanks in advance.
Flags: needinfo?(gfritzsche)
Yes, thank you.
Flags: needinfo?(gfritzsche)
Status: RESOLVED → VERIFIED
Verified fixed with 42.0b1 (Build ID: 20150921151815), across platforms [1].

[1] Windows 7 64-bit, Mac OS X 10.11 Beta and Ubuntu 14.04 32-bit
Flags: qe-verify+
Depends on: 1229781
You need to log in before you can comment on or make changes to this bug.