Closed Bug 1180720 Opened 11 years ago Closed 5 years ago

Stop doing reader mode stuff in DOMContentLoaded

Categories

(Firefox for Android Graveyard :: Reader View, defect)

34 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: snorp, Assigned: snorp)

Details

Right now we parse the document for reader view in DOMContentLoaded. This is very early in the page load cycle, and can slow down the actual page load. We should do it in 'load' or something later on.
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #0) > Right now we parse the document for reader view in DOMContentLoaded. This is > very early in the page load cycle, and can slow down the actual page load. > We should do it in 'load' or something later on. The good news is that we do *way* less work than we used to do. We decided to do this in DOMContentLoaded for desktop, so that we could show the reader view button ASAP, and we decided to keep mobile consistent. However, in our UI, the reader view button takes up the same place as the stop button, so there isn't actually the same benefit to doing this earlier. So yes, let's make this change. I can try to write a patch.
Assignee: nobody → margaret.leibovic
snorp said he would write a patch. We could probably just get rid of the DOMContentLoaded listener in here, and rely exclusively on the pageshow listener: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/content.js#75
Assignee: margaret.leibovic → snorp
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.