Closed Bug 1180859 Opened 9 years ago Closed 9 years ago

[Control Center] Remove special icon for EV certs and use a single DV/EV icon instead

Categories

(Firefox :: General, defect, P1)

Product:
Firefox
Component:
General
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 42
Iteration:
42.1 - Jul 13
Tracking Flags:
Tracking Status
firefox41 + verified
firefox42 + verified

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

(Whiteboard: [fxprivacy] [campaign])

Attachments

(1 file)

0001-Bug-1180859-Control-Center-Remove-special-icon-for-E.patch
9.98 KB, patch
Gijs
: review+
rbarnes
: feedback+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
DV currently gets a grey lock, and EV a green lock with a block showing the organization name. The control center shows a green lock for DV, and a green lock with a check mark for EV.

Aislinn, Tanvi, and I think we should get rid of the DV/EV distinction with regard to the icons in the URL bar and the control center.

The control center as well as the URL bar should simply display a green lock for secure connections. The organization in the URL bar and the control center puts enough emphasis on the identity part of EV, doing anything more would signal that the connection is more secure than with a DV cert.
Flags: firefox-backlog?
Whiteboard: [fxprivacy]
Assignee: nobody → ttaubert
Blocks: 1175678
Status: NEW → ASSIGNED
Iteration: --- → 42.1 - Jul 13
Points: --- → 1
Flags: qe-verify+
Flags: firefox-backlog? → firefox-backlog+
[Tracking Requested - why for this release]:

The restyle landed in 41 and we'd want to uplift the change there as well.
status-firefox42: affected → ---
tracking-firefox41: --- → ?
Comment on attachment 8630099 [details] [diff] [review]
0001-Bug-1180859-Control-Center-Remove-special-icon-for-E.patch

Richard, can you please sign this off? Bug 1175678 would unify the URL bar icons itself so that for TLS (DV + EV) there would always be a green lock. EV only gets the additional block showing the organization name.
Attachment #8630099 - Flags: feedback?(rlb)
Blocks: 1174990
Rank: 4
Priority: -- → P1
QA Contact: mwobensmith
Comment on attachment 8630099 [details] [diff] [review]
0001-Bug-1180859-Control-Center-Remove-special-icon-for-E.patch

Review of attachment 8630099 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me assuming f+ from the relevant folks.
Attachment #8630099 - Flags: review?(gijskruitbosch+bugs) → review+
Tracking for 41, 42 because affected.
tracking-firefox41: ? → +
tracking-firefox42: --- → +
Comment on attachment 8630099 [details] [diff] [review]
0001-Bug-1180859-Control-Center-Remove-special-icon-for-E.patch

Review of attachment 8630099 [details] [diff] [review]:
-----------------------------------------------------------------

Concept LGTM.

I'm assuming that conn-secure.svg is added somewhere?
Attachment #8630099 - Flags: feedback?(rlb) → feedback+
Thanks! The patch renames conn-secure-dv.svg to conn-secure.svg.
https://hg.mozilla.org/mozilla-central/rev/0c47fbb1c6ce
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment on attachment 8630099 [details] [diff] [review]
0001-Bug-1180859-Control-Center-Remove-special-icon-for-E.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1146282
[User impact if declined]: EV certs have a different icon in the control center than DV certs.
[Describe test coverage new/current, TreeHerder]: None.
[Risks and why]: Very low risk, combines two icons into one.
[String/UUID change made/needed]: None.
Attachment #8630099 - Flags: approval-mozilla-aurora?
Is the green lock with the check mark exposed anywhere in aurora?  I don't see it in the url bar or the control center on my nightly.
Yes, it's in the control center. That's what uplifting this bug would fix.
Testing with latest m-c hourly build I don't see any checkmark on the green lock either in the URL bar or in the control-center when I click on the lock-icon.

I still see Green-lock with Site-name displayed, perhaps a change that is not showing up int he control-center re-design ?

https://people.mozilla.org/~shorlander/mockups/Control-Center/Control-Center-i01-02.html
(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #13)
> Testing with latest m-c hourly build I don't see any checkmark on the green
> lock either in the URL bar or in the control-center when I click on the
> lock-icon.

Good, that's what this bug is about.

> I still see Green-lock with Site-name displayed, perhaps a change that is
> not showing up int he control-center re-design ?

Not sure what you mean? If you're referring to the organization name in green to the right of the green lock then that's only shown for EV certs (e.g. mozilla.org). It's not shown for DV certs (e.g. google.com).
(In reply to Tim Taubert [:ttaubert] from comment #14)
> (In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #13)
> > Testing with latest m-c hourly build I don't see any checkmark on the green
> > lock either in the URL bar or in the control-center when I click on the
> > lock-icon.
> 
> Good, that's what this bug is about.
> 
> > I still see Green-lock with Site-name displayed, perhaps a change that is
> > not showing up int he control-center re-design ?
> 
> Not sure what you mean? If you're referring to the organization name in
> green to the right of the green lock then that's only shown for EV certs
> (e.g. mozilla.org). It's not shown for DV certs (e.g. google.com).


Yes I meant the org name, but not on all sites that use EV.

paypal.com  shows the green lock and org name, but there is NO checkmark shown.
(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #15)
> paypal.com  shows the green lock and org name, but there is NO checkmark
> shown.

Yes, the checkmark icon is gone. Gone gone. Are we maybe talking past each other? :)
(In reply to Tim Taubert [:ttaubert] from comment #16)
> (In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #15)
> > paypal.com  shows the green lock and org name, but there is NO checkmark
> > shown.
> 
> Yes, the checkmark icon is gone. Gone gone. Are we maybe talking past each
> other? :)

Apparently.  I was going by this mock-up:
https://people.mozilla.org/~shorlander/mockups/Control-Center/Control-Center-i01-02.html

dated from April 9, 2015

If this mock-up is no longer valid it should probably be removed/updated to reflect what is now 'real world' to avoid confusion.

Sorry for the noise.
Oh yes, these mockups are no longer valid. We have new ones here:

https://www.dropbox.com/sh/1ebphwquhclq2cj/AACJSPjWpglX1fFUS0xw0ghIa?dl=0
Comment on attachment 8630099 [details] [diff] [review]
0001-Bug-1180859-Control-Center-Remove-special-icon-for-E.patch

Patch looks non-invasive (minor UI/icon changes only), has been in m-c for a week. Let's uplift to Aurora.
Attachment #8630099 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Needs rebasing.
Flags: needinfo?(ttaubert)
Whiteboard: [fxprivacy] → [fxprivacy] [campaign]
(In reply to Tim Taubert [:ttaubert] (on PTO, back Aug 31st) from comment #0)
> DV currently gets a grey lock
This is not fixed (grey) in FF 41b3.
Fixed (green) in 42.0a2 (2015-08-24).

> The control center shows a green lock for DV, and a green lock with a check mark for EV.
Fixed (green without the check mark) in 41b3, 42.0a2 (2015-08-24)
(In reply to Paul Silaghi, QA [:pauly] from comment #22)
> (In reply to Tim Taubert [:ttaubert] (on PTO, back Aug 31st) from comment #0)
> > DV currently gets a grey lock
> This is not fixed (grey) in FF 41b3.
Thoughts?
Flags: needinfo?(ttaubert)
(In reply to Paul Silaghi, QA [:pauly] from comment #22)
> (In reply to Tim Taubert [:ttaubert] (on PTO, back Aug 31st) from comment #0)
> > DV currently gets a grey lock
> This is not fixed (grey) in FF 41b3.

The control center is fine, the URL bar is showing a grey icon. It's not great that they're not in sync but we probably don't want to uplift bug 1175678...

Maybe we should one-off fix this for Beta?
Flags: needinfo?(ttaubert)
(In reply to Tim Taubert [:ttaubert] from comment #24)
> Maybe we should one-off fix this for Beta?

I think we don't want to do that. The control center isn't as visible as the lock icon in the URL bar and we'll want to announce the URL bar change more publicly for 42.
Verified fixed FF 41b3 based on comment 25.
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: