Closed
Bug 1180918
Opened 11 years ago
Closed 11 years ago
ESLint: Add "avoid-escape" to quotes
Categories
(DevTools :: General, defect)
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Firefox 42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: jfong, Assigned: jfong)
Details
Attachments
(1 file)
|
1.05 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
Currently ESLint will throw an error if we have to use single quotes to avoid escaping double quotes within a string value. If we apply avoid-escape, it will allow this exception so we don't have to do something like "escape \"string like this\"" to make it pass the warning.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8630167 -
Flags: review?(pbrosset)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8630167 [details] [diff] [review]
Bug1180918.patch
Review of attachment 8630167 [details] [diff] [review]:
-----------------------------------------------------------------
Cool, I somehow had missed this option, I was thinking we'd have to write our own rule for this instead. So, good catch.
Thanks.
Attachment #8630167 -
Flags: review?(pbrosset) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
|
||
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•