1180961 - Edge gestures and home button broken after swiping and hitting home

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

STR:

1.) Open two apps, I used messages and settings.
2.) Swipe left to go back to the previous app.
3.) Before the loading overlay is removed, hit the home button.

Expected result:
The app is minimized, and the homescreen is displayed.

Actual result:
The app stays on the screen. Furthermore, hitting the home button or trying to do an edge gesture does nothing. You have to open the task manager to get out of this one.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Note: this does not reproduce every time, so it seems like some sort of a race condition.

This happens on Flame too, but it seems slightly harder to reproduce.

Comment 2

[Gregor Wagner [:gwagner]]

Is this a regression?

Comment 3

[Shally Li（leave from Mozilla）]

This bug can be repro on latest Flame v2.2&master, but can't be repro on latest Flame v2.1 by the STR of comment 0. This is a regression.

Actual results: The app stays on the app screen. Furthermore, hitting the home button or trying to do an edge gesture does nothing. You have to long tap home button for opening task manager to get out of this one.

See attachment: Flame_v2.2.3gp and logcat_0505.txt.
Reproduce rate: 6/6


---------------------------------------------------------------------------------
Device: Flame v2.1 build(unaffected)
Build ID               20150706001204
Gaia Revision          d13826b20b4a45e3f5cd4b25a30a737d8be7f1b9
Gaia Date              2015-07-02 23:36:46
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/37de99064c33
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150706.040506
Firmware Date          Mon Jul  6 04:05:17 EDT 2015
Bootloader             L1TC000118D0

Device: Flame v2.2 (affected) 
Build ID               20150706002507
Gaia Revision          ea11f422b687a982f0a961c9aea7858066561707
Gaia Date              2015-07-02 23:37:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c0214b4c1ea0
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150706.035706
Firmware Date          Mon Jul  6 03:57:18 EDT 2015
Bootloader             L1TC000118D0

Device: Flame master (affected)
Build ID               20150706010204
Gaia Revision          dc6c18c0dea7af3c40bfff86c530fd877d899dc4
Gaia Date              2015-07-04 01:35:20
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/136c41fca853
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150706.051656
Firmware Date          Mon Jul  6 05:17:08 EDT 2015
Bootloader             L1TC000118D0

Comment 4

[Shally Li（leave from Mozilla）]

Attachment: logcat_0505.txt

Comment 5

[Shally Li（leave from Mozilla）]

Attachment: Flame_v2.2.3gp

Comment 6

[Etienne Segonzac (:etienne)]

Guess I'm having race conditions for lunch today :)

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1180961 > mozilla-b2g:master

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8630506 [details] [review]
[gaia] etiennesegonzac:bug-1180961 > mozilla-b2g:master

We already had come race prevention with StackManager#commitClose but it was called to late.
And this patch is also fixing another smaller race (with a comment explaining it).

Comment 9

[Alberto Pastor [:albertopq]]

Comment on attachment 8630506 [details] [review]
[gaia] etiennesegonzac:bug-1180961 > mozilla-b2g:master

LGTM. Thanks!

Comment 10

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/80ebbe3f3d72dcd00d52139d32e567a894613ed6

Comment 11

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest nightly build of Flame master by the STR in Comment 0.

Actual results: The app doesn't stay on the app screen and backs to Homescreen normally.
See attachment: verified_Flame_master.3gp
Reproduce rate: 0/10


Device: Flame master (Verified)
Build ID               20150709160207
Gaia Revision          bdddfe1ebb796e2bc1c048d5c4e0f97f3d06f98b
Gaia Date              2015-07-09 11:58:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/adfdc7f29ba7
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150709.193215
Firmware Date          Thu Jul  9 19:32:27 EDT 2015
Bootloader             L1TC000118D0

Comment 12

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_master.3gp