Closed
Bug 1180985
Opened 9 years ago
Closed 9 years ago
JS GDB pretty-printers: need support for GCCellPtr
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file, 1 obsolete file)
|
6.35 KB,
patch
|
tromey
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8630253 -
Flags: review?(ttromey)
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jimb
|
|
Assignee | |
Comment 1•9 years ago
|
||
Wrong patch, sorry.
Attachment #8630253 -
Attachment is obsolete: true
Attachment #8630253 -
Flags: review?(ttromey)
Attachment #8630486 -
Flags: review?(ttromey)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8630486 [details] [diff] [review] Implement a JS GDB pretty-printer for JS::GCCellPtr. Review of attachment 8630486 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #8630486 -
Flags: review?(ttromey) → review+
|
|
Assignee | |
Updated•9 years ago
|
Severity: normal → minor
Flags: in-testsuite+
Target Milestone: --- → mozilla42
|
||
Comment 4•9 years ago
|
||
sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b65c048414f7 since one of this changes might have caused bug 1188799 at least started with this pushes
|
|
||
Comment 7•9 years ago
|
||
and re-checkedin since this turned out to be innocent. sorry Jim :(
You need to log in
before you can comment on or make changes to this bug.
Description
•